Bug 130793 - Basic Dialog does not import/export images
Summary: Basic Dialog does not import/export images
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
6.1.0.3 release
Hardware: All All
: medium normal
Assignee: Samuel Mehrbrodt (CIB)
URL:
Whiteboard: target:7.0.0 target:6.3.6 target:6.4.2
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Regressions-imageHandling
  Show dependency treegraph
 
Reported: 2020-02-20 07:08 UTC by Samuel Mehrbrodt (CIB)
Modified: 2020-02-26 10:57 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Mehrbrodt (CIB) 2020-02-20 07:08:25 UTC
1. Open Dialog designer (Tools->Macros->Organize Dialogs)
2. Create a new dialog
3. Edit the new dialog
4. Add an image control (using the bottom toolbar)
5. Select any image for the image control (using General->Graphics on the left side)
6. Export the dialog (File->Export dialog)

Now open the exported file with any editor.

Expected:
The <img> control does have a path to the selected image

Actual:
No image path was exported.

(Importing a dialog with an image control which already has an image path set also does not work.)
Comment 1 Samuel Mehrbrodt (CIB) 2020-02-20 07:09:21 UTC
Regression from 

commit 043273e721ade64e4fb42f969cf22b4202c6b80d
Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>
Date:   Thu Mar 15 09:49:02 2018 +0900

    xmlscript: change import/export to not use GraphicObject URL

https://cgit.freedesktop.org/libreoffice/core/commit/?id=043273e721ade64e4fb42f969cf22b4202c6b80d
Comment 2 Commit Notification 2020-02-26 05:40:54 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6d9cf22b2239611a6612a7855f8a701ed723cbd4

tdf#130793 Fix import/export of image URLs

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Xisco Faulí 2020-02-26 10:56:24 UTC
Verified in

Version: 7.0.0.0.alpha0+
Build ID: e6b9bc3f2ecf0fb7fde5b02f9d750ccbe022f4c1
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

@Samuel, thanks for fixing this issue!
Comment 4 Commit Notification 2020-02-26 10:57:35 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "libreoffice-6-3":

https://git.libreoffice.org/core/commit/bb1d0511ff4f6a3f1c5019472eb04550e0745557

tdf#130793 Fix import/export of image URLs

It will be available in 6.3.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2020-02-26 10:57:49 UTC
Samuel Mehrbrodt committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/a563d4279e383de3f84379b6393188bcbcb64a95

tdf#130793 Fix import/export of image URLs

It will be available in 6.4.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.