Steps to reproduce: 1. Open writer 2. Insert a date form 3. Save it 4. Check the file in https://odfvalidator.org/ or check content.xml -> Untitled 1.odt/content.xml[2,4452]: Error: unexpected attribute "form:input-required" issue found while working on creating a unittest for date forms: https://gerrit.libreoffice.org/c/core/+/89985 Reproduced in Version: 7.0.0.0.alpha0+ Build ID: c57d6d39c80844c9d4c6bfed85cc151e52a67b34 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded
Not reproduced in Version: 5.4.0.0.alpha1+ Build ID: 9feb7f7039a3b59974cbf266922177e961a52dd1 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; Locale: en-US (en_US.UTF-8); Calc: group
This started to happen after https://cgit.freedesktop.org/libreoffice/core/commit/?id=97a0a7f403d9514b6dc9017e6c1ac603efa9576c, before that, the validator asserts Untitled 1.odt/content.xml[2,4424]: Error: unexpected attribute "form:validation" so, not sure it's a regression Adding Cc: to Lionel Elie Mamane
The above commit didn't introduce that attribute, it just made it so it is always written out, whereas before it was written out only in case it was not set at its default value. If you create an odb file with an older LibreOffice, then change the default value of the "Input Required" property of the control, then save, you will find this attribute in the file. Call it a LibreOffice extension, call it something that should be added to the standard in a future version, but it definitely isn't new. Certainly at least as old as LibreOffice (inherited from OpenOffice.org).
Created attachment 158415 [details] reproduction with LibreOffice 5.0 For reference, here is a Writer document with that tag present, generated with LibreOffice 5.0
The ODF standard has the element <form:properties> as child element of a form control. This is intended to carry implementation-dependent properties: <quote> In addition to the attributes defined in this standard, controls may have implementation-dependent attributes. Those attributes are stored in a <form:properties> element in each control. </quote> from section 13.5.1 General in part 3, ODF 1.3. Therefore I suggest, that instead of the invalid attribute form:input-required such <form:property> element is used. @Michael, do you agree? And if yes, how should a transition be done?
we could do that in 2 steps, first add an import for the new way and then a couple years later change the export to remove the invalid attribute. but perhaps we could try to get it into ODF 1.4 which shouldn't be too far off, that would be less effort. this exists since: commit 7a5d79f2297a43d0a854e304b0792164272edfe0 Author: Release Engineers <releng@openoffice.org> AuthorDate: Mon Dec 1 12:31:27 2008 +0000 CWS-TOOLING: integrate CWS dba31e
Dear Xisco Faulí, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug