Bug 131149 - Super/Subscript and Line Spacing options in menu can't be unchecked (with text box objects)
Summary: Super/Subscript and Line Spacing options in menu can't be unchecked (with tex...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
3.5.0 release
Hardware: x86-64 (AMD64) All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Textbox Character
  Show dependency tree / graph
 
Reported: 2020-03-05 10:37 UTC by Brian
Modified: 2024-11-02 12:23 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:

Attachments
Example .odf file showing inconsistent behavior of text in drawing objects (34.52 KB, application/vnd.oasis.opendocument.text)
2022-06-21 18:54 UTC, Brian 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian 2020-03-05 10:37:25 UTC 
Description:
The check marks in the Format->Text->[Superscript, Subscript] and Format->Spacing->[Line Spacing 1, Line Spacing 1.5, Line Spacing 2] menu options persist after they have been used to remove the property. They correctly change the property on the selected text (as does the toolbar and sidebar buttons), but the check mark isn't removed. I can get all the options to have check marks even though they should be exclusive. It seems like the state of the selected text is not queried or properly communicated to the function that sets up the menu entries. It persists when selecting text (or placing the type bar) into several different text boxes. Placing the type bar on normal text, then invoking the menu "resets" the check marks. Double clicking in a box with subscript text and invoking the menu seems to "set" the subscript value. Double clicking on other text boxes with unmodified text will now show the incorrect check mark. However, double clicking in a box with subscript text and NOT invoking the menu, then double clicking in a box with unmodified text shows the correct cleared checkbox.

The same behavior happens to the Format->Spacing->Line Spacing settings. 

This only applies to text placed in a 'text box' or other draw object added from the Basic Shapes toolbar button. When working with regular text, the check mark behavior is correct. It is also restricted to Writer.

Steps to Reproduce:
1. Open Writer, new file
2. Create a text box or basic shape, add text.
3. Create a text box, add text, subscript it.
4. Check the Format menu (Subscript is checked correctly)
5. Double click in the normal text box
6. Check the Format menu (Subscript is checked incorrectly)
7. Select subscripted text, and use Format menu to change it to superscript
8. Double click in the normal text box
9. Check the Format menu (Subscript and Subscript are checked incorrectly)
10. Type in some standard text
11. Check the Format menu (both unchecked correctly)
12. Double click in the normal text box
13. Check the Format menu (both unchecked correctly)
14. Double click in the now superscripted text box
15. Check the Format menu (Subscript is checked correctly)

Actual Results:
see above

Expected Results:
see above


Reproducible: Always


User Profile Reset: No



Additional Info:
Probably not related to https://bugs.documentfoundation.org/show_bug.cgi?id=131087 but I found it while I was confirming the fix in 6.4.2.1.

Version: 6.4.1.2
Build ID: libreoffice-6.4.1.2-snap1
CPU threads: 12; OS: Linux 5.3; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

Also happens in: Version: 6.4.2.1 (pre-release, fresh install)
Build ID: c92dba0b4728c0ec26c4b83e2c0fbf3284425375
CPU threads: 12; OS: Linux 5.3; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: CL
Comment 1 Dieter 2020-03-11 19:49:17 UTC 
I tried to reproduce it

1. Open Writer, new file
2. Create a text box or basic shape, add text.
3. Create a text box, add text, subscript it.
4. Check the Format menu (Subscript is checked correctly)
5. Double click in the normal text box
6. Check the Format menu
(DIFFERENT RESULT: Normal is checked)

7. Select subscripted text, and use Format menu to change it to superscript
8. Double click in the normal text box
9. Check the Format menu
(DIFFERENT RESULT: Normal is checked)

So for me everything looks right with

Version: 7.0.0.0.alpha0+ (x64)
Build ID: c63148ba139bd6b9ae7a0f9e24e51f29e5370963
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded
Comment 2 Buovjaga 2020-05-16 15:14:52 UTC 
(In reply to Brian from comment #0)
> Steps to Reproduce:
> 1. Open Writer, new file
> 2. Create a text box or basic shape, add text.
> 3. Create a text box, add text, subscript it.
> 4. Check the Format menu (Subscript is checked correctly)
> 5. Double click in the normal text box
> 6. Check the Format menu (Subscript is checked incorrectly)

Reproduced on Windows and Linux (master). In 4.4.7 and older, I had to first add Subscript to some menu. I reproduced with 4.4.7, but not with 4.3.0. I was looking into bibisecting with Linux 44max repo, but there is something wrong with it as I was unable to see commands added into menus!!
Comment 3 Buovjaga 2020-06-12 12:20:56 UTC 
My last comment was wrong: it is important to open the Format menu when checking the actually subscripted text status. If you don't do this, the normal text will not be shown as subscripted in the menu either. I see this behaviour already in 3.5.0.
Comment 4 QA Administrators 2022-06-13 03:26:22 UTC Comment hidden (obsolete)
Comment 5 Brian 2022-06-21 18:54:08 UTC 
Created attachment 180882 [details]
Example .odf file showing inconsistent behavior of text in drawing objects

Bug is still present in 7.3.4.2
Comment 6 QA Administrators 2024-06-21 03:17:44 UTC Comment hidden (obsolete)
Comment 7 Brian 2024-11-02 12:23:14 UTC 
Still present in version: 7.3.7.2
Ubuntu package version: 1:7.3.7-0ubuntu0.22.04.7