Bug 131260 - FILEOPEN: DOCX: outer table is missing
Summary: FILEOPEN: DOCX: outer table is missing
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.0.0
Keywords: bibisected, bisected, filter:docx, regression
Depends on:
Blocks: DOCX-Tables
  Show dependency treegraph
 
Reported: 2020-03-10 18:06 UTC by Xisco Faulí
Modified: 2020-03-11 09:21 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison MSO 2010 and LibreOffice 7.0 master (305.63 KB, image/png)
2020-03-10 18:06 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-03-10 18:06:30 UTC
Created attachment 158570 [details]
Comparison MSO 2010 and LibreOffice 7.0 master

Steps to reproduce:
1. Open attachment 101174 [details] from bug 80097

-> Outer table is not visible. See attached comparison image

Reproduced in

Version: 7.0.0.0.alpha0+
Build ID: 976cabe84f3b6e5591ccf2b043d72cbca3e31ba0
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2020-03-10 18:07:57 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4d5c0eaf3e0d3d3bcd9e691fffee19b75f3d6631

author  László Németh <nemeth@numbertext.org>   2020-02-17 14:34:11 +0100
committer       László Németh <nemeth@numbertext.org>   2020-02-19 16:46:18
+0100
commit  4d5c0eaf3e0d3d3bcd9e691fffee19b75f3d6631 (patch)
tree    6ed8e4a013884c28db01b9175dfc933141b7c395
parent  faa2e7b7227b6b87379e7e136ea9ab63f37c3fc4 (diff)
tdf#118812 DOCX import: fix table style preference – part 2

Bisected with: bibisect-linux64-6.5

Adding Cc: to László Németh
Comment 2 Xisco Faulí 2020-03-10 18:18:57 UTC
Actually this got fixed by

author	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2020-03-06 12:39:32 +0100
committer	Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>	2020-03-09 10:33:04 +0100
commit 2b7e24334c9b9c69c1ebf03ed66a2143c6aec972 (patch)
tree f7a278515983a356ca499c5040c83d0dfe2e8c30
parent cb5fc86005a85af06d8ad0bf1ac7aab7649c0048 (diff)
tdf#131184 Allow comparing text ranges in table with body text
Comment 3 Xisco Faulí 2020-03-10 20:30:00 UTC
I've added a unittest in https://gerrit.libreoffice.org/c/core/+/90306
Comment 4 Commit Notification 2020-03-11 08:45:03 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4983e10459d1b1dcf53fbecafc37b1d9dc13f382

tdf#131260: Add unittest

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2020-03-11 09:21:31 UTC
Verified in

Version: 7.0.0.0.alpha0+
Build ID: dde0cf9eafed91c88d9999a294ea32fe0e8aa4bc
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded

@Samuel, thanks for fixing this issue!!