Bug 131549 - No titlebar on modal dialogs on macOS
Summary: No titlebar on modal dialogs on macOS
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All macOS (All)
: high normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.0.0
Keywords: bibisectRequest, regression
: 131925 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-03-24 20:20 UTC by Thorsten Wagner
Modified: 2020-04-28 10:29 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (511.81 KB, image/png)
2020-03-24 20:21 UTC, Thorsten Wagner
Details
Screenshot 2 (290.49 KB, image/png)
2020-03-27 12:14 UTC, Thorsten Wagner
Details
Screenshot 3 (316.13 KB, image/png)
2020-04-17 22:09 UTC, Thorsten Wagner
Details
Strawman (312.54 KB, image/png)
2020-04-17 22:10 UTC, Thorsten Wagner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Wagner 2020-03-24 20:20:56 UTC
Description:
Most of the dialogs are modal dialogs attached to the window frame on macOS now. Window decoration has been disappeared for these dialogs (see screenshot attached). This kind of dialogs have to be attached to window frame, but position is still centered to respective window.

Steps to Reproduce:
1. Open LO
2. Open preference dialog while Startcenter is visible

Actual Results:
Much too wide dialog dropdown animation causes Startcenter window to jump to the middle of dropdown animation. Dialog is displayed centered and not attached to window frame.

Expected Results:
Dropdown animation has correct width, Startcenter window keeps its position, and dialog is rendered attached to Startcenter window frame.


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
Same behaviour happens for many other dialogs, e.g. for dialogs activated from the sidebars (see screenshot attached). I am wondering, if modal dialogs attached to window frames are a desired, but unfinished implemenation, or if it is an regression.

Issue is independet of Open GL.
Comment 1 Thorsten Wagner 2020-03-24 20:21:20 UTC
Created attachment 158958 [details]
Screenshot
Comment 2 Ahmad Haris 2020-03-27 11:54:40 UTC
I'm sorry, can you explain more clearly? such as which menu that need to open?
Comment 3 Thorsten Wagner 2020-03-27 12:13:45 UTC
Attached another screenshot from LibreOffice / Preferences dialog box as described in steps to reproduce, issue is the same
Comment 4 Thorsten Wagner 2020-03-27 12:14:09 UTC
Created attachment 159065 [details]
Screenshot 2
Comment 5 Thorsten Wagner 2020-04-17 22:09:31 UTC
@ Heiko:

Please doublecheck this issue from an UI perspective. Question is whether using dropping down modal dialogs is intended or a regression.

To compare I attached another screenshot 3, which shows current behaviour, and a strawman (created with an image editor), which shows correct result of a dropping modal dialog attached to window frame.

Issue has to be fixed urgently, because it is a blocker for LO 7 on macOS (at least from my point of view).
Comment 6 Thorsten Wagner 2020-04-17 22:09:54 UTC
Created attachment 159668 [details]
Screenshot 3
Comment 7 Thorsten Wagner 2020-04-17 22:10:19 UTC
Created attachment 159669 [details]
Strawman
Comment 8 Alex Thurgood 2020-04-18 16:50:38 UTC
Looks like this is related to bug 131925
Comment 9 Heiko Tietze 2020-04-23 11:46:05 UTC
*** Bug 131925 has been marked as a duplicate of this bug. ***
Comment 10 Heiko Tietze 2020-04-23 11:48:39 UTC
/confirming 

Vanilla 6.4.0.3 has a titlebar and dialogs can be moved around while master doesn't.
Comment 11 Noel Grandin 2020-04-25 20:31:26 UTC
fixed with commir 0ffbaecea3316a5c723f6e0eb7250611b5d0f3d7