Bug 132061 - Page Columns in Notebookbar is not disabled when document is read-only
Summary: Page Columns in Notebookbar is not disabled when document is read-only
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:24.2.0
Keywords:
Depends on:
Blocks: Notebookbar-Tabbed Page-Layout-Columns Read-Only
  Show dependency treegraph
 
Reported: 2020-04-12 08:05 UTC by Jim Raykowski
Modified: 2023-08-19 13:40 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2020-04-12 08:05:33 UTC
In the Tabbed users interface Layout tab the Page Columns control is active when the document is in read-only mode. Seems to me it should be disabled.
Comment 1 Dieter 2020-04-15 11:52:32 UTC
I confirm it with

Version: 7.0.0.0.alpha0+ (x64)
Build ID: 962b415edb47187737a5f05c4ff3f6724a19c564
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

and I agree, that it shouldn't be active
=> NEW
Comment 3 QA Administrators 2023-03-22 03:24:01 UTC Comment hidden (obsolete)
Comment 4 Dieter 2023-04-05 08:37:57 UTC
Bug still present in

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 1e9f4de320f67d1218c710bcee1969a2324c6888
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-US (de_DE); UI: en-GB
Calc: CL threaded
Comment 5 Justin L 2023-06-16 17:56:24 UTC
This was added in the massive commit d02f75a8c36705924ddd6a5921fe3012fafce812
Author: Oliver-Rainer Wittmann on Wed Apr 10 08:20:16 2013 +0000
    Resolves: #i121420# merge sidebar feature
Comment 6 Commit Notification 2023-06-16 19:42:30 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/967c8db8e1ebee924b185b7476df712189e4e51b

tdf#132061: disable uno:PageColumnType when read-only

It will be available in 24.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Dieter 2023-08-13 15:14:58 UTC
Tested with

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: e25e27c85ed970cdb97c468bdac86c80964f4231
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

Page column control is no longer active. Thank you, Justin!. But it is still possible to open the submenu. Would be better and in line with other menus, if you can't open it. What do you tink, Justin?
Comment 8 Justin L 2023-08-14 14:48:53 UTC
(In reply to Dieter from comment #7)
> Page column control is no longer active.  
> But it is still possible to open the submenu.
I can't reproduce. The little drop-down arrow beside "Page Columns" in the notebookbar layout tab is disabled the same as Page Size etc.

My testing routine:
-open a writer document and go to layout tab. Notice everything is active.
-Edit menu - turn off edit mode (or review tab - Edit mode)
-back to layout tab - notice everything is disabled, including Page Column v.
Comment 9 Dieter 2023-08-19 13:40:52 UTC
I confirm, it is fixed in latest master

Version: 24.2.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 34d32740d89876c3d4fd2743a07d6e2578601683
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL threaded

Thank you for fixing it, Justin!