Bug 132119 - NB Tabbed or Tabbed Compact UI mode: incorrectly enable Layout controls during read-only mode opening, and crash if you attempt change page orientation
Summary: NB Tabbed or Tabbed Compact UI mode: incorrectly enable Layout controls durin...
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: haveBacktrace
Depends on:
Blocks: Notebookbar-Tabbed Read-Only
  Show dependency treegraph
 
Reported: 2020-04-15 12:00 UTC by Dieter
Modified: 2022-05-02 17:48 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
NB Tabbed UI calling Sidebar's pageorientationcontrol.cxx, in error for a Read-only session (2.13 KB, text/plain)
2020-04-15 15:23 UTC, V Stuart Foote
Details
WinDbg full process trace (35.77 KB, text/plain)
2020-04-15 15:38 UTC, V Stuart Foote
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dieter 2020-04-15 12:00:38 UTC
Steps to reproduce

1. UI: Tabbed Toolbar
2. Open document in read only mode
3. Tab Layout => Orientation: change from portrait to landscape
=> Crash

Expected result: Impossible to change page layout in read only mode

Found in

Version: 7.0.0.0.alpha0+ (x64)
Build ID: 962b415edb47187737a5f05c4ff3f6724a19c564
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: de-DE (de_DE); UI-Language: en-GB
Calc: threaded

and in 

Version: 6.4.3.2 (x64)
Build-ID: 747b5d0ebf89f41c860ec2a39efd7cb15b54f2d8
CPU-Threads: 4; BS: Windows 10.0 Build 18363; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: threaded
Comment 1 V Stuart Foote 2020-04-15 14:44:33 UTC
Can not reproduce on Windows 10 Home 64-bit en-US with
Version: 6.4.2.2 (x64)
Build ID: 4e471d8c02c9c90f512f7f9ead8875b57fcb1ec3
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded

A document created with Writer, just DummyText, and properties Security -> Read-only check box set and saved.

With User Interface set to NB Tabbed view, document opens annotated "(read-only)" but the Tabbed NB 'Layout' tab does not enable the 'Orientation' button and the 'Layout' listbox shows '<no selection possible>'.

=> NEEDINFO, STR on how are you creating entering into a 'Read only' mode that is crashing?
Comment 2 Xisco Faulí 2020-04-15 15:10:45 UTC
Orientation is greyed out for me in

Version: 7.0.0.0.alpha0+
Build ID: 24e1563b5db3de5abac0d4fd0f737ec319e703e8
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 3 V Stuart Foote 2020-04-15 15:23:11 UTC
Created attachment 159588 [details]
NB Tabbed UI calling Sidebar's pageorientationcontrol.cxx, in error for a Read-only session

OK see it now. The NB Tabbed UI mode makes use of controls used from the Sidebar Decks.

When using the os File manager's 'Read-only' check box when opening--LibreOffice recognizes the 'read-only' asking if you want to edit in a notice bar. Dismiss that, and while the Sidebar Page deck controls are disabled, the NB Tabbed UI 'Layout' controls are not. That is a problem!

Selecting the Layout -> Orientation button action and attempting a change from Portrait to Landscape will crash LO.  Crash report[1]

WinDbg callStack attached.


=-ref-=
[1] crashreport.libreoffice.org/stats/crash_details/bcb0eb14-3a0b-4eaf-b6b4-811a71288685
Comment 4 V Stuart Foote 2020-04-15 15:38:38 UTC
Created attachment 159589 [details]
WinDbg full process trace
Comment 5 QA Administrators 2022-04-16 03:51:53 UTC Comment hidden (obsolete)
Comment 6 Dieter 2022-05-02 17:48:53 UTC
(In reply to V Stuart Foote from comment #3)
> When using the os File manager's 'Read-only' check box when
> opening--LibreOffice recognizes the 'read-only' asking if you want to edit
> in a notice bar.

I've tried to reproduce the problem, but LO doesn't ask me, if i want to edit the document. So i can't reproduce anymore

=> RESOLVED WORKSFORME

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 83d0f2eebae41d431d9a5bfd1a918523977752d0
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: CL