Bug 132242 - Font feature incorrectly applied in Libreoffice to Alegreya typeface
Summary: Font feature incorrectly applied in Libreoffice to Alegreya typeface
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
6.3.5.2 release
Hardware: x86-64 (AMD64) All
: medium normal
Assignee: Julien Nabet
URL:
Whiteboard: target:7.0.0
Keywords:
: 133073 135157 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-04-18 21:04 UTC by Zoltan Laszlo
Modified: 2022-07-28 08:21 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Laszlo 2020-04-18 21:04:28 UTC
Description:
If you open a LibreOffice document and choose the Alegreya typeface, on accessing Character>Feature, you may choose between two Fraction styles: diagonal (frac=1) or nut (frac=2). If you press Ok, one of them (the chosen one) will be applied. Whatever other option you select and press Ok, the selected Fraction style will be applied. You can not select frac=0, or no fraction style. I guess there should also be a checkbox next to Fraction style. It works the same in Writer, Calc and Impress, too.
There is a workaround: after applying the desired features edit the text in the Font: field and delete frac=... however it is not so elegant, there should be a check box next to the stubbornly self-applying feature, as I said above.

Steps to Reproduce:
1.Open a new document.
2. Go to Character, select the Alegreya typeface.
3. Choose a feature (anything) and one of the Fraction styles will be applied.
4. Press OK.

Actual Results:
One of the Fraction styles will be applied. You can not select no fraction style.

Expected Results:
Besides the offered fraction styles it should be possible to chose 'None'.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Version: 6.3.5.2 (x64)
Build ID: dd0751754f11728f69b42ee2af66670068624673
CPU threads: 16; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: ro-RO (en_GB); UI-Language: en-GB
Calc: CL

OpenGL Report follows:
Renderer: AMD Radeon HD 7000 series
Vendor: ATI Technologies Inc.
Version: 4.5.13399 Core Profile Forward-Compatible Context 15.201.1151.1008
Shading language version: 4.40
Comment 1 Julien Nabet 2020-04-19 11:06:58 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this.

But there are also these:
- frac option has some impact visually but frac=1 and frac=2 are very similar effects, quite difficult to distinguish them.
- also when closing and reopening the dialog, ":frac=1"/":frac=2" disappears.
I don't know if it's expected.
However, if I use both of them at different locations, I can see their associated font indicate "Alegray" with frac option.

Xisco/Heiko: any thoughts here?
Comment 2 Heiko Tietze 2020-04-20 11:37:27 UTC
(In reply to Julien Nabet from comment #1)
> - frac option has some impact visually but frac=1 and frac=2 are very
> similar effects, quite difficult to distinguish them.

I don't see any difference ;-)

> Xisco/Heiko: any thoughts here?

The dropdown has a blank entry when you open it the first time (though not selectable). We should introduce a "No Fraction" option.
Comment 3 Heiko Tietze 2020-04-20 11:40:40 UTC
(In reply to Heiko Tietze from comment #2)
> I don't see any difference ;-)

IIUC, the nut fraction should be a horizontal line between numerator and factor.
Comment 4 Julien Nabet 2020-04-20 16:40:48 UTC
Thank you Heiko for your feedback!
Patch on gerrit here:
https://gerrit.libreoffice.org/c/core/+/92591
Comment 5 Commit Notification 2020-04-22 07:45:58 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d28c9d56df8a2629321bda116a6d2dcfa587d160

tdf#132242: add "None" entry for "frac" OpenTypeFeature (vcl)

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 V Stuart Foote 2020-05-15 21:59:03 UTC
*** Bug 133073 has been marked as a duplicate of this bug. ***
Comment 7 V Stuart Foote 2020-07-26 15:19:40 UTC
*** Bug 135157 has been marked as a duplicate of this bug. ***