Download it now!
Bug 132253 - CHARACTER DIALOG: Drop hyperlink from character attributes
Summary: CHARACTER DIALOG: Drop hyperlink from character attributes
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.1.2 release
Hardware: x86-64 (AMD64) Linux (All)
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: needsDevAdvice
Depends on:
Blocks: Character-Dialog Hyperlink-Dialog
  Show dependency treegraph
 
Reported: 2020-04-19 11:32 UTC by Jan Kratochvil
Modified: 2020-04-22 10:04 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
no text selected for right mouse button (43.73 KB, image/png)
2020-04-19 11:32 UTC, Jan Kratochvil
Details
Hyperlink dialog with no "Text:" entry (43.80 KB, image/png)
2020-04-19 11:33 UTC, Jan Kratochvil
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jan Kratochvil 2020-04-19 11:32:34 UTC
Created attachment 159709 [details]
no text selected for right mouse button

libreoffice-writer-6.4.1.2-1.fc33.x86_64

oowriter
right-click on empty area of the page
Character->Character...
HyperLink
URL
http://www.example.com
("Text:" field remains empty)
OK

Nothing happens. Document remains unmodified. "http://www.example.com" gets lost.

There should be some warning trying to set hyperlink for no object / no text.
This makes Bug 132150 more annoying.
Comment 1 Jan Kratochvil 2020-04-19 11:33:15 UTC
Created attachment 159710 [details]
Hyperlink dialog with no "Text:" entry
Comment 2 Dieter 2020-04-19 12:08:37 UTC
Even if you insert text, this text won't be displayed in the document (same bug or another bug?)

If you insert hyperlink without text with Insert => Hyperlink the hyperlink is displayed (could also be an option for hyperlink tab of the character dialog. To be hinest, I wasn't aware of this option in character dialog (and I also don't know, if it is needed here)

cc: Design-Team for further input for a desired solution

I change status to NEW
Comment 3 Heiko Tietze 2020-04-20 10:54:27 UTC
Insert > Hyperlink: foo.com (without text) adds foo.com to the document, with text the it's inserted with the link. Tested with 6.3 on a new and blank document. What's the difference?
Comment 4 Dieter 2020-04-20 10:58:23 UTC
(In reply to Heiko Tietze from comment #3)
> Insert > Hyperlink: foo.com (without text) adds foo.com to the document,
> with text the it's inserted with the link. Tested with 6.3 on a new and
> blank document. What's the difference?

Heiko, this bug is not about the hyperlink dialog, but about hyperlink tab in character dialog. I wouldn't expect such a tab there (paragraph dialog hasn't got it).
Comment 5 Regina Henschel 2020-04-20 11:15:26 UTC
The Hyperlink tab shouldn't be there at all. The item "Character" is about applying a style to characters and a hyperlink is no style but content.

In case it has been intended to allow to set the style of a hyperlink while creating a hyperlink, that can go to the hyperlink dialog.
Comment 6 Heiko Tietze 2020-04-20 11:43:04 UTC
So we either remove the tab completely (+1 for this) or make the text field working. Meaning if you apply the formatting to some selection it contains the text but is disabled. If the field is editable and empty you have to insert some text. I would block the Ok button until this condition is met.

Jan, would you agree with removing the hyperlink tab?
Comment 7 Dieter 2020-04-20 12:02:50 UTC
(In reply to Heiko Tietze from comment #6)
> So we either remove the tab completely (+1 for this)

+1 from my side. Hperlink dialog also provides more options  (for exaple link to other documents).
Comment 8 Jan Kratochvil 2020-04-20 18:31:13 UTC
(In reply to Heiko Tietze from comment #6)
> Jan, would you agree with removing the hyperlink tab?

I was expecting to just hide/disable the Hyperlink tab in the Character dialog iff there is no text selected.

I had to discover there exists the Insert->Hyperlink possibility. Yes, it makes some sense that the hyperlink is "inserted", I was more searching how to "Format" an existing text to add a hyperlink to it.
Comment 9 Heiko Tietze 2020-04-22 10:04:43 UTC
So let's get rid of it. UI-wise we could hide the tab but I wonder what code lingers behind.