Bug 132269 - FILEOPEN DOCX Rejecting tracked change makes floating table with CT disappear
Summary: FILEOPEN DOCX Rejecting tracked change makes floating table with CT disappear
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: DOCX-Track-Changes
  Show dependency tree / graph
 
Reported: 2020-04-20 09:18 UTC by NISZ LibreOffice Team
Modified: 2024-01-10 15:02 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Example file from Word (12.43 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-04-20 09:18 UTC, NISZ LibreOffice Team 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2020-04-20 09:18:34 UTC 
Created attachment 159750 [details]
Example file from Word

Attached document contains an added paragraph and a floating table with text changes inside: addition and deletion.
Opening this file in Writer the changes in the table do not appear in the Manage Changes dialog, only the first paragraph.
When the document texts tracked change is rejected, the whole floating table disappears.

Steps to reproduce:
    1. Open attached document
    2. Reject the single change visible in the Manage Changes dialog or right click menu

Actual results:
Floating table disappears.

Expected results:
Floating table is not affected by the rejection of the previous paragraph.

LibreOffice details:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 94a7ceae287a7967e8f013d012673e26637c6bb5
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: GL; VCL: win; 
Locale: hu-HU (hu_HU); UI-Language: en-US
Calc: CL

Also in:
Verzió: 6.4.0.3 (x86)
Build az.: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8
CPU szálak: 4; OS: Windows 6.3 Build 9600; Felületmegjelenítés: alapértelmezett; VCL: win; 
Területi beállítások: hu-HU (hu_HU); Felület nyelve: hu-HU
Calc: CL

But not in:
Verzió: 6.3.0.4 (x86)
Build az.: 057fc023c990d676a43019934386b85b21a9ee99
CPU szálak: 4; OS: Windows 6.3; Felületmegjelenítés: alapértelmezett; VCL: win; 
Területi beállítások: hu-HU (hu_HU); Felület nyelve: hu-HU
Calc: CL
Comment 1 NISZ LibreOffice Team 2020-04-24 08:46:28 UTC 
ooops, forgot this part:

Bibisected using bibisect-win64-6.4 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=e75dd1fc992f168f24d66595265a978071cdd277
author	Michael Stahl <Michael.Stahl@cib.de>	2019-12-05 16:49:33 +0100
committer	Michael Stahl <michael.stahl@cib.de>	2019-12-06 14:44:42 +0100
tdf#121300 sw: consistent fly at-pargraph selection
Comment 2 Michael Stahl (allotropia) 2020-06-11 16:51:36 UTC 
the reason is that the floating table is anchored at the start of the section (the body text), and the tracked change goes from the start of the section to the end of the section.

i don't think i want to fix this, i don't see an obvious way to do it.

in the docx the table isn't contained in the insertion redline, but i'm afraid Writer's model can't represent that situation currently.

it might be useful to add some list of inserted/deleted flys at the edge to SwRangeRedline but that would be a lot of work.
Comment 3 Gabor Kelemen (allotropia) 2022-02-10 09:59:41 UTC 
Magic words for search:

Adding CC: to Michael Stahl