Bug 132334 - Skia: Rulers in Draw have no tick marks
Summary: Skia: Rulers in Draw have no tick marks
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.0.0
Keywords:
Depends on:
Blocks: Skia
  Show dependency tree / graph
 
Reported: 2020-04-22 21:21 UTC by Regina Henschel
Modified: 2020-05-11 08:29 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Rulers with Skia enabled (4.18 KB, image/png)
2020-04-22 21:21 UTC, Regina Henschel 		Details
Rulers with OpenGL (4.35 KB, image/png)
2020-04-22 21:21 UTC, Regina Henschel 		Details
Ruler tics Skia Vulkan rendering (5.49 KB, image/png)
2020-04-23 13:22 UTC, V Stuart Foote 		Details
Ruler tics Skia Raster rendering (4.58 KB, image/png)
2020-04-23 13:23 UTC, V Stuart Foote 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2020-04-22 21:21:07 UTC 
Created attachment 159826 [details]
Rulers with Skia enabled

The rulers in Draw have no tick marks, if I use Skia. Tick marks exist, if I use OpenGL.

I see the error in a debug build.
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 688a520111a2dd3ab4cb3b846b561936d8a887bf
CPU threads: 8; OS: Windows 10.0 Build 18362; UI render: Skia/Vulkan; VCL: win; 
Locale: de-DE (en_US); UI-Language: en-US
Calc: CL
Comment 1 Regina Henschel 2020-04-22 21:21:59 UTC 
Created attachment 159827 [details]
Rulers with OpenGL

This shows, how the rulers should be rendered.
Comment 2 V Stuart Foote 2020-04-23 13:19:01 UTC 
On Windows 10 Home 64-bit (1909) with Intel HD Graphics

RenderMethod: vulkan
Vendor: 0x8086
Device: 0x5916
API: 1.2.131
Driver: 0.401.3889
DeviceType: integrated
DeviceName: Intel(R) HD Graphics 620
Blacklisted: no

(2020-04-18 TB77)
Version: 7.0.0.0.alpha0+ (x64)Build ID: 96f77910e86f88c99621a8b17c09fc69f9f1d8f3CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; Locale: en-US (en_US); UI-Language: en-USCalc: threaded

With Skia Vulkan rendering, the tics are present but are rendered in a light gray matching the background color of the ruler.

With Skia Raster rendering, the tics are rendered dark.
Comment 3 V Stuart Foote 2020-04-23 13:22:45 UTC 
Created attachment 159852 [details]
Ruler tics Skia Vulkan rendering
Comment 4 V Stuart Foote 2020-04-23 13:23:25 UTC 
Created attachment 159853 [details]
Ruler tics Skia Raster rendering
Comment 5 Commit Notification 2020-04-24 08:47:13 UTC 
Luboš Luňák committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c69d4edf61a2647ba8d6104c743e5f2d2cbc4229

fix tick marks in Draw with Skia (tdf#132334)

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 V Stuart Foote 2020-04-25 14:05:13 UTC 
Confirmed with TB77 build for 2020-04-25, ruler tics returned to Vulkan rendering
Version: 7.0.0.0.alpha0+ (x64)
Build ID: fe1cf8656d6963844553993a77ef565fb2fbeda7
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 7 BogdanB 2020-05-11 08:29:44 UTC 
Everything ok now.

Version: 7.0.0.0.alpha1
Build ID: 6a03b2a54143a9bc0c6d4c7f1...
CPU threads: 4; OS: Linux 5.4; UI render: Skia/Raster; VCL: x11; 
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded