Bug 132366 - Highlight search results in the Writer's Navigator Content view
Summary: Highlight search results in the Writer's Navigator Content view
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.1.0
Keywords:
Depends on:
Blocks: Navigator
  Show dependency treegraph
 
Reported: 2020-04-23 21:34 UTC by Jim Raykowski
Modified: 2020-09-25 06:42 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
demonstration of navigator outlines selection when findall search is done (2.63 MB, video/x-matroska)
2020-04-23 21:34 UTC, Jim Raykowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Raykowski 2020-04-23 21:34:44 UTC
Created attachment 159876 [details]
demonstration of navigator outlines selection when findall search is done

Hi All,

Attach is a demo of an enhancement request that I did for a LO user. Would this be something that would be used enough to include in the releases? It hasn't received any comments at ask.libreoffice.org site.

https://ask.libreoffice.org/en/question/234564/highlight-search-results-in-the-writers-navigator-content-view/
Comment 1 V Stuart Foote 2020-04-24 13:55:16 UTC
@Jim, very useful for editing. A quick visual location of where in document tree the search string is located--supplementing normal Find Bar or Navigator deck's 'Repeat Search' and 'Find all' support.

+1
Comment 2 Dmitry 2020-04-24 14:06:58 UTC
I was the one who requested this feature.

A visual representation of the search in the document tree acts as a "heat map" of the search results inside the document.

In the use case when the headings represent some context (such as Years / Months / Dates or any other dependencies) this feature comes at hand with the ability to export/copy the selected tree nodes to the clipboard.

+1
Comment 3 V Stuart Foote 2020-04-24 16:51:21 UTC
@UX-advise, logical progression of function, don't see much need for UX input, more an FYI...
Comment 4 Jim Raykowski 2020-04-25 05:34:06 UTC
Here is a link to a patch that does what is shown in the demo, tweaked to handle floating Navigator without having to set Outline tracking off:

https://gerrit.libreoffice.org/c/core/+/92886
Comment 5 Jim Raykowski 2020-04-25 05:44:44 UTC
(In reply to Dmitry from comment #2)
> this feature comes at hand with
> the ability to export/copy the selected tree nodes to the clipboard.
> 

+1 from me. May be a good one for you to take on. Please open a new enhancement request for this.
Comment 6 Heiko Tietze 2020-04-29 15:17:35 UTC
Typical flaw of this interaction is when you want to step through the found placed and the highlighting abused for identification breaks on click, ie. when the user wants to go to this place. Example: You search for "Text", find something on p2,4,9 and double-click the Navigator on the p2 finding. I bet the multi-selection is gone (if not we have an even bigger issue).

But no objection to the addition. It's just a bit broken in itself.
Comment 7 Roman Kuznetsov 2020-09-12 19:17:59 UTC
So, Jim, I see an abandoned patch in gerrit. Will you plan to continue your work around this or may be after Heiko's comment you'll want just close it as WONTFIX yourself?
Comment 8 Jim Raykowski 2020-09-20 03:24:42 UTC
(In reply to Roman Kuznetsov from comment #7)
> So, Jim, I see an abandoned patch in gerrit. Will you plan to continue your
> work around this or may be after Heiko's comment you'll want just close it
> as WONTFIX yourself?

Roman, 
Thanks for reminding about this. I have restored it and made some improvements.
Comment 9 Commit Notification 2020-09-20 06:26:20 UTC
Jim Raykowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6f7f5f280abaf4ee84472359acd4952b2eea40a4

tdf#132366 Writer enhancement that highlights search results

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.