Description: Changes made to text elements in a specific SmartArt are lost upon saving as PPTX. Steps to Reproduce: 1. Open sample PPTX document 2. Edit text in the top two / left two elements 3. Save document (still as PPTX) 4. Restart LibreOffice 5. Open saved document Actual Results: All text changes have disappeared, reverted to the original status. Expected Results: Text changes survive safe - restart - open cycle. Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.0.0.alpha0+ Build ID: 2e9261415006ce782a7ae699c69f5be3cec29dff CPU threads: 4; OS: Linux 5.6; UI render: default; VCL: gtk3; TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-04-22_02:33:36 Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded
Created attachment 159880 [details] Sample PPTX document
Confirmed in LO 7.0.0.0.alpha0+ (f924658e45f256544e43c3fdb2af9b585d0f0933) & 6.3.0.4 / Ubuntu. Edited text is retained after save&reload in 6.2.0.3. => regression
Bibisected to the following commit using repo bibisect-linux-64-6.3. https://cgit.freedesktop.org/libreoffice/core/commit/?id=aafaf1f55fa413ad49d4556cf7c0a713dd206ae4 author Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com> 2019-03-13 10:49:30 +0100 committer Miklos Vajna <vmiklos@collabora.com> 2019-04-08 10:07:35 +0200 PPTX export: save SmartArt as diagram instead of group of shapes
Hej Miklos, I figured you might be interested in this regression since you committed the patch (as part of last year's SmartArt work).
I'll take a look.
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a01ae07740e5c311fcc37f2ac2e2a0a2a1935920 tdf#132368 svx: empty the interop grab-bag on ending text edit It will be available in 7.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I think this is now fixed on master.
I do confirm the issue is fixed in Version: 7.2.0.0.alpha0+ / LibreOffice Community Build ID: 43e306ebe61ef5a849dcfd1e74b697be3b3fe716 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Miklos, thanks for fixing this issue!!
attachment 159880 [details] seems to suffer from fileopen bug for shape text position, since 4.2.x. Previously,text size was too small but later text position is not fully correct and in center of shape like in MSO. As always, needs to be searched first and See Also to this bug.
(In reply to Timur from comment #9) > attachment 159880 [details] seems to suffer from fileopen bug for shape text > position, since 4.2.x. Previously,text size was too small but later text > position is not fully correct and in center of shape like in MSO. > As always, needs to be searched first and See Also to this bug. Timur, do you mean bug #132302 ?
(In reply to Gerald Pfeifer from comment #10) > (In reply to Timur from comment #9) > > attachment 159880 [details] seems to suffer from fileopen bug for shape text > > position, since 4.2.x. Previously,text size was too small but later text > > position is not fully correct and in center of shape like in MSO. > > As always, needs to be searched first and See Also to this bug. > > Timur, do you mean bug #132302 ? Yes. You should always link via See Also, that you did only now. Also, once file is uploaded no need to upload again, just write attachment 12345.
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-1": https://git.libreoffice.org/core/commit/4bf14305dfa22a3e4084b630b6924a718d7da3ce tdf#132368 svx: empty the interop grab-bag on ending text edit It will be available in 7.1.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/4ddde32ea6807eaa686ad25aa18ea24a8b834df8 tdf#132368 svx: empty the interop grab-bag on ending text edit It will be available in 7.0.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.