Bug 132718 - gallery: Shapes didn't use styles
Summary: gallery: Shapes didn't use styles
Status: RESOLVED INSUFFICIENTDATA
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-05 13:16 UTC by andreas_k
Modified: 2022-06-23 03:49 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description andreas_k 2020-05-05 13:16:54 UTC
If you draw an shape with styles store them in the gallery the gallery item look the same than the shape with style. If you export the gallery item to another file, the styles don't work only if you say clean direct formating.

If you use styles the definition should be stored in the gallery item (already did)
If you move an gallery item to a new file the gallery item should use the styles (if available) which will be now only possible after say Clear direct formating. If style is not available (writer don't support shape styles), direct formating style should be used.
Comment 1 Regina Henschel 2020-05-05 14:26:57 UTC
(In reply to andreas_k from comment #0)
> If you draw an shape with styles store them in the gallery the gallery item
> look the same than the shape with style.

That is because dragging a shape to the gallery performs a "burn in styles", which sets the style attribute values as direct formatting.

> If you export the gallery item to another file,

What is "export" here?

> the styles don't work only if you say clean direct formating.

What do you mean by "styles don't work"?

> 
> If you use styles the definition should be stored in the gallery item
> (already did)

What makes you think, that the style definition is in the gallery item?
Comment 2 andreas_k 2020-05-05 15:31:30 UTC
It's not easy to describe for me. I will try it again.

For BPMN, Flowchart, Network gallery items I will draw the shapes with Default and Accent 2 Drawing Style. So that if I have full style support for the gallery items, I will have something like this:

https://www.youtube.com/watch?v=IfvQXQLIAlI

Gallery items have burn in styles, BUT remember the origin style, so if you use an gallery item from e.g. network it will be blue (direct formating) when select clean direct formating, it will use Default and Accent 2 Drawing Style again.

Impress and Draw has Drawing Styles, calc and writer don't have drawing styles (see BUG 89369). So the perfect workflow woul be IF an gallery item would use the style from the file if the style is available and if not use the "burn in styles" (direct formating).

I'd like to add styles support to the gallery items and if an user use an gallery item, the gallery item will follow the document style (if the style is available) if not, gallery item will use "burn in style" (as it is now).
Comment 3 andreas_k 2020-05-05 15:34:42 UTC
So in general I need an 

IF * Drawing Style (Default, Accent 2) is available use it
ELSE use "burn in styles" (as we have now)
Comment 4 Regina Henschel 2020-05-05 20:11:12 UTC
(In reply to andreas_k from comment #2)
> I'd like to add styles support to the gallery items

How do you will add a style information to a gallery item? AFAIK currently the gallery items do not have style information.
Comment 5 andreas_k 2020-05-05 20:44:53 UTC
https://gerrit.libreoffice.org/c/core/+/93498

Will be available in the daily build on 06.05. move an Bpmn gallery item to an impress template, ungroup and remove direct formating. Than Bpmn will use default and accent 2 style from the impress template.

Everything is already in the gallery.
Comment 6 QA Administrators 2020-05-06 03:45:43 UTC Comment hidden (obsolete)
Comment 7 Heiko Tietze 2020-05-07 14:19:44 UTC
(In reply to Regina Henschel from comment #1)
> (In reply to andreas_k from comment #0)
> That is because dragging a shape to the gallery performs a "burn in styles",
> which sets the style attribute values as direct formatting.

bug 115460
Comment 8 Xisco Faulí 2020-06-17 14:40:11 UTC
@Andreas, @Heiko, what's the current status of this issue?
Comment 9 Xisco Faulí 2021-11-23 10:44:14 UTC
(In reply to Xisco Faulí from comment #8)
> @Andreas, @Heiko, what's the current status of this issue?

Setting to NEEDINFO
Comment 10 Heiko Tietze 2021-11-23 13:48:44 UTC
Comment 5 sounds like WFM but I'd make it a DUP according comment 7.
Comment 11 QA Administrators 2022-05-23 03:38:51 UTC Comment hidden (obsolete)
Comment 12 QA Administrators 2022-06-23 03:49:03 UTC
Dear andreas_k,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp