Bug 132743 - Table style alternating row formatting not retained when inserting new rows after redo sequence
Summary: Table style alternating row formatting not retained when inserting new rows a...
Status: RESOLVED DUPLICATE of bug 143244
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Writer-Tables-Style
  Show dependency treegraph
 
Reported: 2020-05-05 20:14 UTC by Telesto
Modified: 2021-07-22 17:31 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screencast (958.49 KB, video/mp4)
2020-09-01 20:27 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-05-05 20:14:07 UTC
Description:
Wrong table formatting after redo

Steps to Reproduce:
1. Open Writer
2. Insert a table 
3. Choose a table style: Box list blue
4. Hold tab -> Table increases... proper formatting
5. CTRL+A
6. CTRL+X
7. CTRL+V
8. CTRL+Z -> everything until start
9. CTRL+Y the first table insertion and tab key press

Actual Results:
Blue table

Expected Results:
Same as initial


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 97a2c1fc5e376c0c00968f17a0392c6d3a5ed565
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc:
Comment 1 Buovjaga 2020-08-31 17:40:33 UTC
I have no idea what you've got going on in the steps.

I guess you mean "Hold Ctrl-Tab", if the idea is to insert tabulator characters in the table in order to make the height grow?

Step 9 involves hitting Ctrl-Y *until* the tab key presses appear?

I didn't observe anything unusual.

Arch Linux 64-bit
Version: 7.1.0.0.alpha0+
Build ID: d784e711c102f204552c3c816636da01b1085f61
CPU threads: 8; OS: Linux 5.8; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 29 August 2020
Comment 2 Telesto 2020-09-01 18:12:33 UTC
1. Open Writer
2. Insert a table 
3. Choose a table style: Box list blue
4. Put the cursor in the table and Hold tab to few rows get added (fine)
5. CTRL+A
6. CTRL+X
7. CTRL+V
8. CTRL+Z everything
9. CTRL+Y everything
10. Place cursor in table and hold tab 

Table expands in blue (not gray/white)

Steps where slightly incomplete..
Comment 3 Buovjaga 2020-09-01 20:04:09 UTC
(In reply to Telesto from comment #2)
> 10. Place cursor in table and hold tab 
> 
> Table expands in blue (not gray/white)

I don't get it. Table expands in whatever the row is that I placed my cursor in!! Blue, gray, white, just as I would expect it to. What is the point?

To clarify step 5, Ctrl-A to select the Tab characters you just inserted.
Comment 4 Telesto 2020-09-01 20:27:00 UTC
Created attachment 164991 [details]
Screencast
Comment 5 Buovjaga 2020-09-02 17:01:46 UTC
Ok, the problem was that you had apparently customised your keyboard shortcuts, so Tab was inserting new rows. I had no way of knowing what you were actually doing, when you pressed Tab.

I reproduce now. It does not matter, if the table is inserted via toolbar button and later styled or if it is inserted via Table menu.

I tested with 4.4.7, Table menu & Autoformat - Yellow for a 2-row table. The alternating row styles are not realised at all, when I first start inserting rows. So I guess the process was improved at a later point.

Arch Linux 64-bit
Version: 7.1.0.0.alpha0+
Build ID: d784e711c102f204552c3c816636da01b1085f61
CPU threads: 8; OS: Linux 5.8; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 29 August 2020
Comment 6 Telesto 2020-09-02 19:01:00 UTC
@Jim
You did quite a number of those lovely table style issues in the past. For example bug 126833 Not sure if you're still interested, or grown out of fixing this type of bugs
Comment 7 Jim Raykowski 2020-09-03 07:49:46 UTC
Looks like the table style is lost before the undo redo steps. To see this, move the cursor into the table after repro step 7. Notice no table style is highlighted in the sidebar styles deck table panel. I think copy/cut and paste may be the place to begin investigating.
Comment 8 Balázs Sántha 2021-07-06 19:38:52 UTC
(In reply to Jim Raykowski from comment #7)
> Looks like the table style is lost before the undo redo steps. To see this,
> move the cursor into the table after repro step 7. Notice no table style is
> highlighted in the sidebar styles deck table panel. I think copy/cut and
> paste may be the place to begin investigating.

I think you are right. After the fix of missing table styles after copying/cutting + pasting, I can not reproduce this anymore. 
See the fix: https://bugs.documentfoundation.org/show_bug.cgi?id=131771
Comment 9 Balázs Sántha 2021-07-22 12:32:43 UTC
@Telesto
I made a patch for this, what probably fixes this bug. Would you mind to test it?
https://gerrit.libreoffice.org/c/core/+/119249
Comment 10 Buovjaga 2021-07-22 17:31:31 UTC
I verify the fix, thanks

Arch Linux 64-bit
Version: 7.3.0.0.alpha0+ / LibreOffice Community
Build ID: 3957ffb88f9856f2288b5f390609207b2e9c4c2b
CPU threads: 8; OS: Linux 5.13; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 22 July 2021

*** This bug has been marked as a duplicate of bug 143244 ***