Bug 132765 - UI: Page style edit style button opens a new exactly on top of the page style dialog
Summary: UI: Page style edit style button opens a new exactly on top of the page style...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Page-Style-Dialog
  Show dependency treegraph
 
Reported: 2020-05-06 12:42 UTC by Telesto
Modified: 2021-12-03 18:40 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-05-06 12:42:26 UTC
Description:
Page style edit style button doesn't work

Steps to Reproduce:
1. Open Writer
2. Format -> Page Style
3. Select a different next style
4. Press Edit Style few times
5. Press cancel -> Notice it isn't working properly either

Actual Results:
Nothing 

Expected Results:
A dialog


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 97a2c1fc5e376c0c00968f17a0392c6d3a5ed565
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc:
Comment 1 andreas_k 2020-05-07 07:37:59 UTC
can't confirm. I do the steps but it work at my master build.

Version: 7.0.0.0.alpha0+ (x64)
Build ID: 97a2c1fc5e376c0c00968f17a0392c6d3a5ed565
CPU threads: 8; OS: Windows 10.0 Build 16299; UI render: Skia/Raster; VCL: win; 
Locale: de-AT (de_AT); UI-Language: en-GB
Calc: threaded
Comment 2 Telesto 2020-05-08 20:17:25 UTC
Maybe me not being awake.. but I didn't notice the dialog actually opening.. It's exactly on top. This didn't happen in 5.2.
Comment 3 Telesto 2020-05-08 20:27:33 UTC
Compare with Page Style tab -> Footer -> Enable -> More button dialog (opens at a different spot)
Comment 4 Xisco Faulí 2020-05-11 11:49:13 UTC
(In reply to Telesto from comment #0)
> Description:
> Page style edit style button doesn't work
> 
> Steps to Reproduce:
> 1. Open Writer
> 2. Format -> Page Style
> 3. Select a different next style
> 4. Press Edit Style few times
> 5. Press cancel -> Notice it isn't working properly either

What 'Notice it isn't working properly' mean?
When I click Edit dialog it open the dialog and clicking on cancel, closes it.

Version: 7.0.0.0.alpha1+
Build ID: 86bc13248c1d9f63b10aac304bdf0361d1dcc47f
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3; 
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 5 Telesto 2020-05-11 11:59:13 UTC
I really didn't notice a new dialog being opened.. after pressing edit style
Comment 6 Xisco Faulí 2020-05-11 12:02:49 UTC
(In reply to Telesto from comment #5)
> I really didn't notice a new dialog being opened.. after pressing edit style

See the dialog's title. it should have changed...
Comment 7 Telesto 2020-05-11 12:05:54 UTC
(In reply to Xisco Faulí from comment #6)
> (In reply to Telesto from comment #5)
> > I really didn't notice a new dialog being opened.. after pressing edit style
> 
> See the dialog's title. it should have changed...

It does.. but not quite obvious.. Compare it with the Border/background dialog opening when clicking  Page Style tab -> Footer -> Enable -> More button dialog 

The dialog doesn't open on top, but a little next to
Comment 8 Xisco Faulí 2020-05-11 12:08:33 UTC
it seems obvious to me, but yeah, whatever, let the UX team decide what to do then...
Comment 9 Heiko Tietze 2020-05-12 08:29:06 UTC
(In reply to Telesto from comment #2)
> This didn't happen in 5.2.

Same behavior with Version: 5.2.7.2.

Placing the dialog in the center of the parent window is fine. But since Edit opens the same dialog again it's placed on top of the other. So ideally we push it some pixels to the left and down (ideally the size of the dialog's headerbar) until the bottom of the window is reached and start at 0,0 then.