Bug 132853 - UI: Same size settings twice: in Image tabs Type & Crop
Summary: UI: Same size settings twice: in Image tabs Type & Crop
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:25.8.0
Keywords:
Depends on:
Blocks: Image-Dialog
  Show dependency treegraph
 
Reported: 2020-05-08 18:09 UTC by Telesto
Modified: 2025-01-27 10:00 UTC (History)
7 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-05-08 18:09:09 UTC
Description:
UI: Same size settings twice: in Image tabs Type & Crop

Steps to Reproduce:
1. Open Writer
2. insert in image (picture)
3. Select the image -> Format -> Image -> Properties
4. Compare Type & crop dialog

Actual Results:
Same size settings at two places. With crop lacking a keep ratio button. 

Expected Results:
A single place? Or I'm i missing something?


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 97a2c1fc5e376c0c00968f17a0392c6d3a5ed565
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded
Comment 1 Telesto 2020-05-08 18:10:43 UTC
Another Image dialog comment.. Of me, being benjamin..
Comment 2 Heiko Tietze 2020-05-12 08:36:13 UTC
Size at Type tab is the same as on the Crop tab but would you want to switch between the tabs? And if not, which one should be deleted?
Comment 3 Telesto 2020-05-12 08:47:04 UTC
(In reply to Heiko Tietze from comment #2)
> Size at Type tab is the same as on the Crop tab but would you want to switch
> between the tabs? And if not, which one should be deleted?

It has to go from crop.. as there are more settings in Type tab, IMHO

One of the issues. Making changes to the dimensions in crop. Doesn't update the type tab. And visa versa. Also is the crop tab lacking a keep ratio checkbox.

* Will at it.. Increase the size of the Preview Picture.. (as there is room left anyhow).
* And even better make it possible the 'drag' crop borders on the preview screen (similar how the crop tool functions.. with exact numbers next to it..) Cropping with the pressing numbers is not so funny.. only for the final touch..
Comment 4 andreas_k 2020-05-12 11:43:44 UTC
+1 for clean crop tab and have there only crop items.
Comment 5 Heiko Tietze 2020-05-28 12:38:09 UTC
No objection, so let's do it. Could be an easyhack.
Comment 6 Gabor Kelemen (allotropia) 2025-01-16 13:41:28 UTC
*** Bug 157384 has been marked as a duplicate of this bug. ***
Comment 7 Telesto 2025-01-16 18:42:33 UTC
Looking at this again. It appears to not be as simple as plainly dropping the "Image Size' from Crop dialog.

If you change the value in the 'Scale' fields the 'Image Size' will adjust. So Image size is 'needed' in the sense of feedback. If needs to be a input field is different matter. It can simple be a textbox?
Comment 8 Commit Notification 2025-01-24 09:04:25 UTC
Balazs Varga committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/81f7503d2d205f4f6df0bfd1a66ed10cccb556c2

tdf#132853 - UI: fix different sizes in Image tabs Type & Crop

It will be available in 25.8.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Gerald Pfeifer 2025-01-26 15:31:10 UTC
I'll argue that this commit addresses bug #157384 which is not 
actually a full duplicate (and talks to syncing the multiple
occurrences where these values can be configured).

So I VERIFIED that other report and am reopening this one, where
maybe the answer for it as WONTFIX.
Comment 10 Heiko Tietze 2025-01-27 08:41:43 UTC
Telesto, WF?
Comment 11 Telesto 2025-01-27 10:00:50 UTC
(In reply to Heiko Tietze from comment #10)
> Telesto, WF?

WF is fine (for now). I still think that not great being able to edit the 'Image Size' in two Tabs (so having spinbox at both tabs). I resulting in a Text Label only for the crop tab regarding Size. 

The crop tab should handling crop; and nothing else, but this isn't the case (yet). However the design is depended on what type of functions belongs on the crop tab. Bug 164734