Bug 133179 - LibreOffice writer - custom color picker doesn't update its color area
Summary: LibreOffice writer - custom color picker doesn't update its color area
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Color-Picker-Dialog
  Show dependency treegraph
 
Reported: 2020-05-19 21:12 UTC by Shawn Michaels
Modified: 2023-09-08 13:24 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Video of errors (1.68 MB, video/x-matroska)
2020-05-19 21:13 UTC, Shawn Michaels
Details
Example file (9.09 KB, application/vnd.oasis.opendocument.text)
2020-05-24 11:50 UTC, Telesto
Details
table from video (9.68 KB, application/vnd.oasis.opendocument.text)
2020-05-24 14:28 UTC, Shawn Michaels
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Shawn Michaels 2020-05-19 21:12:37 UTC
Description:
1) color picker for table background displays red shades - when I set different color it still displays red shades

2) splitting cells causes font display error and history errors

Steps to Reproduce:
1. Insert table with predefined style
2. Set font to all cells
3. Merge some cells
4. Split cells

1. Set custom cell background
2. select different color

Actual Results:
1) Font settings are lost

2) Actual color gradient is not displayed

Expected Results:
1) Fonts persists

2) Actual color gradient is displayed correctly


Reproducible: Always


User Profile Reset: No



Additional Info:
Tested on two computers same results in 6.3.4.2 and 6.4.3.2
Comment 1 Shawn Michaels 2020-05-19 21:13:57 UTC
Created attachment 161017 [details]
Video of errors
Comment 2 Dieter 2020-05-22 07:21:37 UTC
Shawn, thank you for the bug report. One basic rule in Bugzilla is "One report for each problem". So let's reduce this bug to the first problem (color picker) and open a new report for the second problem. Thank you. I've already changed bug summary.

I also couldn't reproduce the first bug. Could you please add your sample that is showing in the video? Thanks.

=> NEEDINFO
Comment 3 Shawn Michaels 2020-05-24 09:44:58 UTC
OK, and sorry for that, I was in hurry, first time bug report (but not the first time some bug found) and quite a little annoyed :D
What do you mean the sample? ODT file?
Comment 4 Dieter 2020-05-24 11:34:18 UTC
(In reply to Shawn Michaels from comment #3)
> OK, and sorry for that, I was in hurry, first time bug report (but not the
> first time some bug found) and quite a little annoyed :D

Welcome to LO Bugzilla :-)

> What do you mean the sample? ODT file?

Yes, please add odt-file, that is shown in your video.
Comment 5 Telesto 2020-05-24 11:50:08 UTC
Created attachment 161230 [details]
Example file

1. Open the file
2. Select a cell
3. Split the cell (vertical) -> Font setting lost
Comment 6 Telesto 2020-05-24 12:13:10 UTC
Bisected to
author	Jakub Trzebiatowski <ubap.dev@gmail.com>	2016-06-21 00:31:01 +0200
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2016-07-07 09:02:15 +0000
commit 40fba0f4418084d50cc5c388cb0b6e1abe395d61 (patch)
tree 4b1e97aa7755c80d9a8749fb94dc3fe26a2f35fb
parent 046244bcfe1c5c1cd2325fe74b933c05e43cf190 (diff)
GSoC Writer Table Styles Import
This patch is implementing import of table styles (table-template).

Modified shared code: Added "background" to the cell styles export.

To make cell export properties map accessible by both export and import code,
moved from xmloff/source/table/XMLTableExport.cxx to xmloff/txtprmap.hxx.

To avoid export of default valued properties implemented XPropertyState for
SwXTextCellStyle

https://cgit.freedesktop.org/libreoffice/core/commit/?id=40fba0f4418084d50cc5c388cb0b6e1abe395d61


 ~/bibisect-win32-5.3
$ git bisect good f219fe1bb6bc35dcdaea0b996aea3e98fbfb4443 is the first bad commit
commit f219fe1bb6bc35dcdaea0b996aea3e98fbfb4443
Author: Norbert Thiebaud <nthiebaud@gmail.com>
Date:   Sat Jul 9 09:21:22 2016 -0700

    source 40fba0f4418084d50cc5c388cb0b6e1abe395d61

    source 40fba0f4418084d50cc5c388cb0b6e1abe395d61

:040000 040000 07383b2f6d36c207c5cb4cc25bb6d0fd213c71b0 4336911227133ce406383fb8186fcf6af4225f76 M      instdir
Comment 7 Telesto 2020-05-24 12:13:38 UTC
Adding CC to Jakub Trzebiatowski
Comment 8 Shawn Michaels 2020-05-24 14:28:02 UTC
Created attachment 161234 [details]
table from video

color picker error is in this table cell background
Comment 9 Justin L 2021-11-19 13:40:31 UTC
I'm confused. Comment 2 says this will be about the color picker (which I cannot reproduce the problem in bibisect 60, 63, or 73).
But comment 5 and presumably the bibisect are about font stuff.
Comment 10 Stéphane Guillou (stragu) 2023-09-02 00:35:32 UTC
The loss of formatting when splitting a cell is already tracked in bug 143234 (bibisected to the same commit as in comment 6).

Regarding the colour picker issue, I can't reproduce in 5.3 and in a recent master build neither. No one has reproduced so far, so can you please test again in a currently-supported version (7.6 preferably) and report back, Shawn?

Thank you!
Comment 11 Shawn Michaels 2023-09-08 07:29:17 UTC
Hi,
1) color picker seem fixed
2) LO 7.5.5.2 - with new file I was unable to reproduce the error,
but the same LO with attached file https://bugs.documentfoundation.org/attachment.cgi?id=161234
still broke font on cell split and undo action doesn't get state back.
Comment 12 Stéphane Guillou (stragu) 2023-09-08 13:24:31 UTC
(In reply to Shawn Michaels from comment #11)
> Hi,
> 1) color picker seem fixed
> 2) LO 7.5.5.2 - with new file I was unable to reproduce the error,
> but the same LO with attached file
> https://bugs.documentfoundation.org/attachment.cgi?id=161234
> still broke font on cell split and undo action doesn't get state back.

Thanks for testing again!

Let's mark this report as "works for me" for the colour picker issue.

Regarding the table formatting issue, if you don't think bug 143234 covers it already, please open a new report.
Thank you!