Download it now!
Bug 133198 - Unchecking the formatting checkboxes in Autoformat dialog has no effect for the current table
Summary: Unchecking the formatting checkboxes in Autoformat dialog has no effect for t...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
5.3.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Writer-Tables-Style
  Show dependency treegraph
 
Reported: 2020-05-20 15:52 UTC by Telesto
Modified: 2020-09-04 14:01 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Bibisect log (2.91 KB, text/plain)
2020-05-23 21:26 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-05-20 15:52:32 UTC
Description:
Formatting options for Autoformat table styles don't work

Steps to Reproduce:
1. Insert a table
2. Change the font inside the table (DF)
3. Table -> Autoformat 
4. Select a style (Blue/Green/Red/Yellow)
5. Uncheck all formatting options & press OK

While testing bug 121023

Actual Results:
All formatting is applied

Expected Results:
No formatting applied.. or removal of the dialog?


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha1+ (x64)
Build ID: f9790da286f2d2fa47f1748f8cfa6172c6622ca3
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; 
Locale: de-CH (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-05-20 15:55:02 UTC
@Heiko
What do you want to do with Table -> Autoformat styles & the settings available there.. the don't work.. (related: bug 121023). 

Should the dialog go away? Should the settings be moved (bug 121023)
Comment 2 Telesto 2020-05-20 18:49:44 UTC
Pff.. the settings do actually work.. you only need to quite LibreOffice and relaunch.. 

Secondly: the settings Autoformat styles do affect the sidebar too.. so if you disable everything for say Red.. Press OK. Quite LibreOffice. and restart.. and try red using the sidebar.. nothing appears
Comment 3 bhagwat singh 2020-05-21 14:30:22 UTC Comment hidden (spam)
Comment 4 Heiko Tietze 2020-05-22 13:04:00 UTC
(In reply to Telesto from comment #2)
> Pff.. the settings do actually work..

So it's a WFM for you?

(In reply to Telesto from comment #1)
> Should the dialog go away? Should the settings be moved (bug 121023)

Yes, this autoformat dialog should be replaced with something like this https://design.blog.documentfoundation.org/2015/12/13/style-your-tables/

PS: needsUXAdvice requires CC to ux-advice*
Comment 5 Telesto 2020-05-22 13:57:28 UTC
(In reply to Heiko Tietze from comment #4)
> Yes, this autoformat dialog should be replaced with something like this
> https://design.blog.documentfoundation.org/2015/12/13/style-your-tables/

Are there tickets for all those proposals in the bug tracker.. Would be nice to have a meta bug with all the UX-proposals'. Could be practical for see also.. I'm not always looking on the design blog.. and surely not years back.

And is this already on the list for a GSOC.. The whole table style implementation is half house concept. Table -> Autoformat -> influences the sidebar.. If I uncheck some of those settings it will affect table style permanently.. but not an obvious place to manage that.. [And of course: Autoformat functions are also broken (regression).. functioning in an odd way, which isn't helpful either).. 

Also the click table picker (how do you call it.. in the toolbar..) isn't using any template.. and the Insert -> Table always use template.. expect none.. but that table has no borders [should be a bug report about it somewhere]
Comment 6 Heiko Tietze 2020-05-22 14:48:12 UTC
(In reply to Telesto from comment #5)
> Are there tickets for all those proposals in the bug tracker.. 

See bug 105933, and probably some other

> Would be nice to have a meta bug with all the UX-proposals'

There is bug 101756 as META for table styles.

> And is this already on the list for a GSOC...

It was but not finished. Now we have many unfinished bits and pieces, and some larger issue such as bug 49437 that blocks design work.
Comment 7 Telesto 2020-05-23 21:25:48 UTC
The actually issue is: 
Unchecking the formatting checkbox has no effect for the current table. It only works for applying the formatting the next time
Check an unchecked checkbox has immediate effect (as expected)
Comment 8 Telesto 2020-05-23 21:26:49 UTC
Created attachment 161207 [details]
Bibisect log

Bisected to
author	Jakub Trzebiatowski <ubap.dev@gmail.com>	2016-07-26 14:29:40 +0200
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2016-07-27 12:13:18 +0000
commit	b7138e03ebc8a33258c099c5cf6015970646a40e (patch)
tree	6c4a872182c08e96c832e8b1f60b0cfbfdbb162e
parent	9e63e60d6f00ee690fafb9f21f2cafb08a6ad92e (diff)
GSoC Writer Table Styles; Import bugfix
+ Binary autoformats are loaded into document on document creation
+ Imported table styles overwrite existing styles.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=b7138e03ebc8a33258c099c5cf6015970646a40e
Comment 9 Telesto 2020-05-23 21:27:25 UTC
Adding CC to Jakub Trzebiatowski
Comment 10 Buovjaga 2020-09-04 14:01:56 UTC
Repro

Arch Linux 64-bit
Version: 7.1.0.0.alpha0+
Build ID: 6b2eff7d69c6e14d89dd33eaa58c01d82c541266
CPU threads: 8; OS: Linux 5.8; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 4 September 2020