Bug 133304 - Highlight color button doesn't work in writer in a text box if tabbed layout is activated
Summary: Highlight color button doesn't work in writer in a text box if tabbed layout ...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL: https://ask.libreoffice.org/t/no-pued...
Whiteboard: target:7.6.0
Keywords:
: 155363 (view as bug list)
Depends on:
Blocks: Textbox Notebookbar-Tabbed
  Show dependency treegraph
 
Reported: 2020-05-23 12:33 UTC by kdedk
Modified: 2023-06-01 08:22 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description kdedk 2020-05-23 12:33:17 UTC
Description:
The button is disabled if I enter a text box or it does nothing if clicked, but only in tabbed layout, not in standard toolbar layout.

Steps to Reproduce:
1. Create a new writer document.
2. Switch the user interface in writer to tabbed layout.
3. Create a text box.
4. Add some text to the text box (and stay inside the text box with focus).
5. Click on the Highlight Color button.
6. Mark some text INSIDE the text box.

Actual Results:
Either step 5 fails because the button is not clickable (in standard toolbar layout, it is.) or in step 6 marking the text doesn't change it color (in standard toolbar layout, it does.).

Expected Results:
The text that got marked inside the text box changes its color to the color chosen with the highlight color button.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha1
Build ID: 6a03b2a54143a9bc0c6d4c7f1...
CPU threads: 4; OS: Linux 5.6; UI render: default; VCL: gtk3; 
Locale: de-DE (de_DE.utf8); UI: en-US
Calc: threaded
Comment 1 V Stuart Foote 2020-05-23 13:59:40 UTC
Confirmed on Windows with
Version: 7.0.0.0.alpha1+ (x64)
Build ID: b587de60d4e6aa96238766272d94f1499b22f696
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win; 
Locale: en-US (en_US); UI: en-US
Calc: threaded

In the MUFFIN NB Tabbed UI, the Highlight Color widget does not activate for text selection in a Draw text box.  Same document with Standard UI in use, the selection in Draw text box does activate the Highlight color widget and will take a color.
Comment 2 sdc.blanco 2021-02-28 01:24:13 UTC
(In reply to V Stuart Foote from comment #1)
> In the MUFFIN NB Tabbed UI, the Highlight Color widget does not activate for
> text selection in a Draw text box.
.uno:BackColor and .uno:CharBackColor have same widget, but only the latter works in text boxes and shapes.  In the Standard UI, this change happens surreptitiously by having the Text Object bar (with .uno:CharBackColor) replace the Formatting bar (with .uno:BackColor) when Text Boxes are selected.  I am not familiar with the notebookbar*.ui, but maybe this information will give an insight into a possible explanation (and solution) to the problem.  

Meanwhile, it should be possible -- via Tools - Customize to make a personal "repair" of the problem, search for "highight" in the customize dialog.
Comment 3 QA Administrators 2023-03-01 03:21:57 UTC Comment hidden (obsolete)
Comment 4 Stéphane Guillou (stragu) 2023-06-01 08:09:52 UTC
Reproduced when using the tabbed UI. The Home > Character highlighting is greyed out (and the Background Color button will apply a background colour to the paragraph on the page instead of the selected text in the text box, and should probably be hidden, but that's a different issue.)

Version: 7.4.7.2 / LibreOffice Community
Build ID: 723314e595e8007d3cf785c16538505a1c878ca5
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

and in

Version: 7.5.3.2 (X86_64) / LibreOffice Community
Build ID: 9f56dff12ba03b9acd7730a5a481eea045e468f3
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Workarounds: use character highlighting in Sidebar, or use standard UI, or use context menu > character.

However, it is already fixed in:

Version: 7.6.0.0.alpha1+ (X86_64) / LibreOffice Community
Build ID: 60e499147963e42ce783dffcf9c8d4aba8b5d475
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded
Comment 5 Stéphane Guillou (stragu) 2023-06-01 08:11:00 UTC
*** Bug 155363 has been marked as a duplicate of this bug. ***
Comment 6 Stéphane Guillou (stragu) 2023-06-01 08:22:39 UTC
Fixed by Justin Luth in be3d34b5d6b97c3eb12ab3f84ce2da2ef965a928 for bug 85592. (fix bibisected with linux-64-7.6 repo).

Thanks everyone!