Description: Saving performance for a large complex doc slow Steps to Reproduce: 1. Open the attached file 2. Press Save Actual Results: Slow Expected Results: Could need some optimizations Reproducible: Always User Profile Reset: No Additional Info: Version: 7.0.0.0.alpha1+ (x64) Build ID: b587de60d4e6aa96238766272d94f1499b22f696 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; Locale: nl-NL (nl_NL); UI: en-US Calc: CL
Created attachment 161225 [details] Example file
A flamegraph would be nice.. You may need to remove number of pages.. to get a graph within a reasonable time.. It are all copy's of the same.. so shouldn't change the outcome
Created attachment 161226 [details] Example file bit smaller
Created attachment 161231 [details] Flamegraph Here's a Flamegraph retrieved on pc Debian x86-64 with master sources updated today.
it takes 2 minutes and 4 seconds for me in Version: 7.1.0.0.alpha0+ Build ID: 42bf9bdf3d551eb59604f952204c49f7d7a1e913 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
(In reply to Julien Nabet from comment #4) > Created attachment 161231 [details] > Flamegraph > > Here's a Flamegraph retrieved on pc Debian x86-64 with master sources > updated today. Hi Noel, I thought you might be interested in this flamegraph
We spend about 50% of the save time traversing every single property of every single object in the diagram calculating something called AutoStyles. Unfortunately, I do not see any relatively simple way to improve this.
(In reply to Noel Grandin from comment #7) > We spend about 50% of the save time traversing every single property of > every single object in the diagram calculating something called AutoStyles. > > Unfortunately, I do not see any relatively simple way to improve this. Luckily not affected, only the reporter :-)
Dear Telesto, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
40 sec and blinking progress bar in Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community Build ID: bff60eadeac348024849d710690435ee9580831b CPU threads: 4; OS: Windows 10.0 Build 19043; UI render: Skia/Raster; VCL: win Locale: ru-RU (ru_RU); UI: en-US Calc: threaded Intel(R) Core(TM) i5-7300HQ CPU @ 2.50GHz
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/af826c85c2eb519b9a3f76099c0e70604d9679e2 tdf#133343 improve perf of OUString::operator=(&&) It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Noel Grandin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/01a3cc1e55034f7703219d4bbb209de7c37bf07b tdf#133343 collect autostyle prop names It will be available in 7.5.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
1 minute to save with Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: bfe33d42a2381bce194cc6fe15b830902f7c8443 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: ro-RO (ro_RO); UI: en-US Calc: threaded
61 seconds in Version: 7.5.0.0.alpha1+ (X86_64) / LibreOffice Community Build ID: bfe33d42a2381bce194cc6fe15b830902f7c8443 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: ro-RO (ro_RO); UI: en-US Calc: threaded 53 seconds in Version: 7.4.3.2 (x64) / LibreOffice Community Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: ro-RO (ro_RO); UI: en-US Calc: threaded From the moment I press Save until the message "Save document" dissapear from the bottom of the page.