Bug 133367 - macOS: Calc: + and - icons for zoom level in the bottom right not shown when Icon style "Breeze (dark)" is used
Summary: macOS: Calc: + and - icons for zoom level in the bottom right not shown when ...
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All macOS (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: macOS-Dark-Mode
  Show dependency treegraph
 
Reported: 2020-05-25 10:35 UTC by steve
Modified: 2023-03-14 09:50 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
icons for zoom level in calc not shown (12.53 KB, image/png)
2020-05-25 10:36 UTC, steve
Details
- icon breeze dark, light grey on light greywon't work well (63.20 KB, image/png)
2020-05-26 06:01 UTC, steve
Details

Note You need to log in before you can comment on or make changes to this bug.
Description steve 2020-05-25 10:35:51 UTC
Description:
Version: 7.0.0.0.alpha1
Build ID: 6a03b2a54143a9bc0c6d4c7f1...
CPU threads: 8; OS: Mac OS X 10.15.4; UI render: default; VCL: osx; 
Locale: de-DE (de_DE.UTF-8); UI: en-US
Calc: threaded

Calc: + and - icons for zom level not shown

Steps to Reproduce:
open calc

Actual Results:
missing + - icons for zom level

Expected Results:
icons should be shown


Reproducible: Always


User Profile Reset: No



Additional Info:
see screenshot
Comment 1 steve 2020-05-25 10:36:28 UTC
Created attachment 161256 [details]
icons for zoom level in calc not shown
Comment 2 Jean-Baptiste Faure 2020-05-25 10:54:00 UTC
Not reproducible for me in 
Version: 7.0.0.0.alpha1+
Build ID: 7b47a96b20122863e77aa1918e878372b3485c9f
Threads CPU : 4; OS : Linux 4.15; UI Render : par défaut; VCL: gtk3
Locale: fr-FR (fr_FR.UTF-8); UI: fr-FR
Ubuntu_18.04_x86-64
Calc: threaded

MacOS only ?

Best regards. JBF
Comment 3 steve 2020-05-25 11:20:37 UTC Comment hidden (obsolete)
Comment 4 Alex Thurgood 2020-05-25 13:40:16 UTC
No repro here either with
Version: 7.0.0.0.alpha1
Build ID: 6a03b2a54143a9bc0c6d4c7f1...
CPU threads: 8; OS: Mac OS X 10.15.4; UI render: default; VCL: osx; 
Locale: fr-FR (fr_FR.UTF-8); UI: en-US
Calc: threaded
Comment 5 Alex Thurgood 2020-05-25 13:53:21 UTC
Reproduced with Breeze Dark.

1) Open a Calc sheet with default icon theme (Sukapura).
2) Enter Preferences and switch to Breeze Dark (notice how the main toolbar already doesn't display the icons, but the Calc sheet still shows the original zoom icons.
3) Create a new Calc sheet - the icons are missing.
4) Now change back to Sukapura - main toolbar shows all icons, but the Calc sheet created with Breeze Dark still shows no icons.
5) Create a new Calc sheet - zoom icons visible !
Comment 6 steve 2020-05-25 13:57:20 UTC
Actually not sure if this is a regression as it may never have worked to begin with with Icon style "Breeze (dark)"
Comment 7 Heiko Tietze 2020-05-25 14:38:44 UTC
What do you expect with white icons on bright background? Breeze Dark is meant for dark themes. => NAB
Comment 8 steve 2020-05-25 17:53:10 UTC
@Heiko: From what I can tell there are no white icons for + and - at all (see screenshot).

Also I would not expect to change anything at that location when changing icon themes.

Why would + and - change? And if they actually indeed are changing with the icon styles, why does the scale indicator remain dark grey?

All this is very inconsistent and needs cleaning imo.
Comment 9 Heiko Tietze 2020-05-25 18:25:49 UTC
Breeze dark: https://opengrok.libreoffice.org/xref/core/icon-themes/breeze_dark/svx/res/slidezoomout_10.png
Breeze: https://opengrok.libreoffice.org/xref/core/icon-themes/breeze/svx/res/slidezoomout_10.png
Other: https://opengrok.libreoffice.org/s?path=svx/res/slidezoomout_10.png&project=core

What is the scale indicator? Anyway, all other controls are drawn per GDI functions, only icons are up to designers.
Comment 10 steve 2020-05-26 06:00:23 UTC
scale indicator = zoom factor, excuse the wrong terminology
thanks for linking the icons. so breeze dark uses a light grey for the + -. The zoom slider has light dark background so that won't work.

Not sure what a good solution looks like as this is an involved problem and there is no overall concept for dark mode in LO currently.
Comment 11 steve 2020-05-26 06:01:05 UTC
Created attachment 161288 [details]
- icon breeze dark, light grey on light greywon't work well
Comment 12 Heiko Tietze 2020-05-26 08:17:39 UTC
(In reply to steve -_- from comment #11)
> - icon breeze dark, light grey on light greywon't work well

Again, this is not a bug. The icons are designed for use on dark backgrounds. If the default selection is wrong on macOS, please report. However, since 6.4 or maybe 7.0 we have Sukapura as the default icon theme.
Comment 13 steve 2020-06-06 11:49:40 UTC
Understood. The problem here is: if LLO exposes settings to users, the software should ensure that functionality continues to work as expected.
<translating: if dark icon themes are offered in environments that have no proper dark mode support (i.e. LO on macOS), I need to either a) ensure those are only shown when support for dark environment exists or b) ensure no icons become invisible when applied otherwise.
Then again if users use adjusted application colors, hiding dark icon themes will not work for them.

This is covered by adding dark mode support on macOS, which is a complicated effort that will need a few dev resources: https://bugs.documentfoundation.org/show_bug.cgi?id=118017
Comment 14 Rizal Muttaqin 2020-06-06 13:07:45 UTC
My suggestion is to provide some toggle or checklist e.g. "Show all available icon themes" when we got proper dark mode & dark recognition support.