Bug 133437 - FILEOPEN: Frames have no bonder
Summary: FILEOPEN: Frames have no bonder
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Vasily Melenchuk (CIB)
URL:
Whiteboard: target:7.1.0 target:7.0.0.2 target:6.4.7
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-05-27 12:06 UTC by Xisco Faulí
Modified: 2020-08-31 15:14 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison MSO 2010 and LibreOffice 7.0 master (372.04 KB, image/png)
2020-05-27 12:06 UTC, Xisco Faulí
Details
same issue reproduced with attachment 98599 (320.66 KB, image/png)
2020-05-27 16:36 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-05-27 12:06:07 UTC
Created attachment 161330 [details]
Comparison MSO 2010 and LibreOffice 7.0 master

Steps to reproduce:
1. Open attachment 61947 [details] from bug 48440

-> The frames don't have any border. See comparison image

Reproduced in

Version: 7.0.0.0.alpha1+
Build ID: 82894d85147840f1f587e9530b12f0058f2ef2c3
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded


[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2020-05-27 12:07:07 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=0b0de876bad66c84a8dd0d8d19944109e59cf21a

author	Vasily Melenchuk <vasily.melenchuk@cib.de>	2020-05-05 15:47:44 +0300
committer	Thorsten Behrens <Thorsten.Behrens@CIB.de>	2020-05-11 10:52:13 +0200
commit 0b0de876bad66c84a8dd0d8d19944109e59cf21a (patch)
tree 47fd990baf8cdea19e44a604d824ac819a9ce422
parent ea414f8f255d75e3be71c0d65731ff3f42f589ed (diff)
sw: set unique name for shape format even if shape name is empty

Bisected with: bibisect-linux64-6.5

Adding Cc: to Vasily Melenchuk
Comment 2 Vasily Melenchuk (CIB) 2020-05-27 12:16:16 UTC
Reproduced. Interesting effect: frames actually are in document, but they all are on last page.
Comment 3 Xisco Faulí 2020-05-27 16:36:11 UTC
Created attachment 161344 [details]
same issue reproduced with attachment 98599 [details]

Also reproduced with attachment 98599 [details] from bug 78370
Comment 4 Xisco Faulí 2020-05-27 17:24:10 UTC
attachment 78882 [details] from bug 64240 is also affected by this issue
Comment 5 Commit Notification 2020-07-14 08:52:35 UTC
Vasily Melenchuk committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0c53a58b2dd9bee3d4de6843966486428fdaa78f

tdf#133437: sw: set generated shape name if it is missing

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Xisco Faulí 2020-07-14 14:32:57 UTC
Verified in

Version: 7.1.0.0.alpha0+
Build ID: 616a47c9570f9ce67b18a124f08f4a342bff3468
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Vasily, thanks for fixing this issue!!
Comment 7 Commit Notification 2020-07-15 09:10:39 UTC
Vasily Melenchuk committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/9f05cf79a73c9c7dc00bcfb70dd5e3b1464af47b

tdf#133437: sw: set generated shape name if it is missing

It will be available in 7.0.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2020-08-21 06:42:57 UTC
Vasily Melenchuk committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/136c466fa9caa7f9b4d8870d704e41da832e522b

tdf#133437: sw: set generated shape name if it is missing

It will be available in 6.4.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Xisco Faulí 2020-08-31 15:14:05 UTC
Verified in

Version: 7.1.0.0.alpha0+
Build ID: e2f4e65a7b8024c00b049eebf0d87637efda7f24
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Vasily, thanks for fixing this issue!!