Bug 133448 - FILEOPEN: WMF image is empty
Summary: FILEOPEN: WMF image is empty
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.1.0 target:7.0.0.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-05-27 15:47 UTC by Xisco Faulí
Modified: 2020-06-01 13:50 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison MSO 2010 and LibreOffice 7.0 master (43.19 KB, image/png)
2020-05-27 15:47 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-05-27 15:47:06 UTC
Created attachment 161340 [details]
Comparison MSO 2010 and LibreOffice 7.0 master

Steps to reproduce:
1. Open attachment 69765 [details] from bug 56886

-> WMF image on document is empty. See comparison image

Reproduced in

Version: 7.0.0.0.alpha1+
Build ID: 82894d85147840f1f587e9530b12f0058f2ef2c3
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded


[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2020-05-27 15:48:15 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=059f07f9f33460c809a93e0fda1165f5c6f6d805

author	Noel Grandin <noel.grandin@collabora.co.uk>	2020-04-15 18:34:58 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2020-04-16 09:11:41 +0200
commit 059f07f9f33460c809a93e0fda1165f5c6f6d805 (patch)
tree 09bbd8b4daab16e8752b3bcf6e2d3b6602bb801a
parent 2670e980c7dbadbdc20ff23d57ad892951edc254 (diff)
fixes for code creating reversed Rectangles

Bisected with: bibisect-linux64-6.5

Adding Cc: to Noel Grandin
Comment 2 Commit Notification 2020-05-30 17:06:05 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/5f260ecaddbd2b93de18f5223a7a732bcff280d9

tdf#133448 tdf#133435 ignore broken rectangles so can we load dodgy EMF/WMF

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2020-05-31 15:32:58 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/2891e91a513520d68ea2b8c59c14335861a15253

tdf#133448 tdf#133435 ignore broken rectangles so can we load dodgy EMF/WMF

It will be available in 7.0.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Xisco Faulí 2020-06-01 09:27:54 UTC
Verified in

Version: 7.0.0.0.beta1+
Build ID: 2506d8221dd940dfd93d3d7c183430ba6ba3089d
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Noel, thanks for fixing this issue!!
Comment 5 Commit Notification 2020-06-01 13:50:26 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/987de0769fc57ab66ae814e79aa2c4a522c81098

tdf#133448: sw: Add unittest

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.