Bug 133450 - FILEOPEN: lines in OLE Visio Drawing object are blurred
Summary: FILEOPEN: lines in OLE Visio Drawing object are blurred
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: high normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
: 135372 (view as bug list)
Depends on:
Blocks: Visio
  Show dependency treegraph
 
Reported: 2020-05-27 16:12 UTC by Xisco Faulí
Modified: 2021-05-30 06:43 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison MSO 2010 and LibreOffice 7.0 master (120.39 KB, image/png)
2020-05-27 16:12 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-05-27 16:12:28 UTC
Created attachment 161343 [details]
Comparison MSO 2010 and LibreOffice 7.0 master

Steps to reproduce:
1. Open attachment 91648 [details] from bug 73363

-> Lines connecting the textboxes are barely visible. See comparison image

Reproduced in

Version: 7.0.0.0.alpha1+
Build ID: 82894d85147840f1f587e9530b12f0058f2ef2c3
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded


[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2020-05-27 16:13:46 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=dd117712bd5692f7bf3870ba91572a0bab54ab86

author	Armin Le Grand <Armin.Le.Grand@me.com>	2020-03-05 19:24:30 +0100
committer	Armin Le Grand <Armin.Le.Grand@me.com>	2020-03-06 10:10:55 +0100
commit	dd117712bd5692f7bf3870ba91572a0bab54ab86 (patch)
tree	bde473f22e43cc320e3960c331de7051d01ad77e
parent	a3c8951da607d63ac7ffc76a062bb76208ca5ff3 (diff)
tdf#124848 partial refactor hairline logic

Bisected with: bibisect-linux64-6.5

Adding Cc: to Armin Le Grand
Comment 2 Xisco Faulí 2020-05-28 11:00:26 UTC
attachment 118492 [details] is also affected by this issue 93986
Comment 3 Xisco Faulí 2020-05-28 11:23:58 UTC
attachment 49881 [details] from bug 39800 is also affected
Comment 4 Timur 2020-08-02 16:30:32 UTC
*** Bug 135372 has been marked as a duplicate of this bug. ***
Comment 5 Timur 2020-08-02 16:35:30 UTC
Seems Skia only.
Comment 6 Luboš Luňák 2020-08-20 10:37:14 UTC
Does not seem to be Skia only, even the original description says 'gtk3'.

The direct problem is that fLineWidth in drawPolyLine() is way too small, which leads to the lines being so thin (or even not drawn). Why it's so, I have no idea.
Comment 7 Luboš Luňák 2021-01-20 16:15:14 UTC
*** Bug 139144 has been marked as a duplicate of this bug. ***
Comment 8 Xisco Faulí 2021-03-30 19:33:12 UTC
Still reproducible in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 7da7f6ca37c92ab33e34a76fd25efab526b7c80a
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 9 Aron Budea 2021-05-29 23:30:19 UTC
Attachment 132120 [details] from bug 106740 also regressed after this commit, it's a Visio file, and the text boxes have thinner frames since.