Bug 133486 - FILESAVE Save or Save as fails when cell format was changed earlier
Summary: FILESAVE Save or Save as fails when cell format was changed earlier
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.1.0 target:7.0.0.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-05-28 22:09 UTC by Stefan_Lange_KA@T-Online.de
Modified: 2020-06-09 10:02 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan_Lange_KA@T-Online.de 2020-05-28 22:09:43 UTC
(Only) the first attempt to save or "save as" (special) documents results in error message "Error saving document xxx: Write error. The file could not be written."(seen in german: "Fehler beim Speichern des Dokumentes xxx: Schreibfehler. Die Datei konnte nicht geschrieben werden."). At further attempts the error message is not displayed and the document is saved.

Reproduce the problem:
- New -> spreadsheet document
- enter something in cell A1
- select cell A1 and right click in the cell -> Format cells
- change horizontal alignment from "Standard" to "Left"
- save and close the document
- reopen the saved document
- try to save or "save as" the document (without any chhanges)
- error message "Error saving document xxx: Write error. ..." is displayed!

- click OK and try to save again -> document is saved without error message

The problem was reproduced with
version 7.0.0.0.beta1 (x64) (Build 94f789cbb33335b4a511c319542c7bdc31ff3b3c) and also with
version 7.1.0.0.apha0+ (x64) (Build 41d8b41767032681a9897b7551f011d450e3725e).
Comment 1 m_a_riosv 2020-05-31 14:04:19 UTC
Confirmed
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 41d8b41767032681a9897b7551f011d450e3725e
CPU threads: 4; OS: Windows 10.0 Build 19608; UI render: Skia/Raster; VCL: win
Locale: es-ES (es_ES); UI: en-US Calc: threaded
Comment 2 m_a_riosv 2020-05-31 14:06:44 UTC
Works fine
Version: 6.4.5.0.0+ (x64)
Build ID: a3ef13b495d5898488ae52981bdaf8cf34db791c
CPU threads: 4; OS: Windows 10.0 Build 19608; UI render: default; VCL: win; 
Locale: es-ES (es_ES); UI-Language: en-US Calc: threaded
Comment 3 Xisco Faulí 2020-06-03 09:05:42 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=457d2a0c9373937332ad2ec7b16edc4b2c971a97

author	Noel Grandin <noel.grandin@collabora.co.uk>	2020-05-15 15:47:08 +0200
committer	Noel Grandin <noel.grandin@collabora.co.uk>	2020-05-15 18:03:46 +0200
commit 457d2a0c9373937332ad2ec7b16edc4b2c971a97 (patch)
tree 70842a0692c9d2043765540cebebfe5d7f477fb2
parent e125c6c6693d4540ab3aacb11151e05b511b8051 (diff)
fix TODO

Bisected with: bibisect-linux64-6.5

Adding Cc: to Noel Grandin
Comment 4 Commit Notification 2020-06-05 20:04:45 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/bfb807bf6cf07243a88dc1e66883dfcea872ceab

tdf#133486 Revert "fix TODO"

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2020-06-06 17:46:42 UTC
Noel Grandin committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/78abf4065049d16da1bdf878f414a38af498577e

tdf#133486 Revert "fix TODO"

It will be available in 7.0.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Stefan_Lange_KA@T-Online.de 2020-06-07 04:39:40 UTC
Test was OK with
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 933d03e36db2a01cbda3d4ca13f4333d38239d1e
CPU-Threads: 4; BS: Windows 10.0 Build 19640; UI-Render: Skia/Vulkan; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
Comment 7 Stefan_Lange_KA@T-Online.de 2020-06-07 07:27:37 UTC
Test was also OK with
Version: 7.0.0.0.beta1+ (x64)
Build ID: 900ffff8b5718113e5b3ab7e9fbf35b999661c39
CPU-Threads: 4; BS: Windows 10.0 Build 19640; UI-Render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: CL
Many thanks for fixing the bug!
Comment 8 Xisco Faulí 2020-06-09 10:02:32 UTC
Verified in

Version: 7.1.0.0.alpha0+
Build ID: e0f058bcd5e185b89e4b7c680a7901bc7eb2a790
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Noel, thanks for fixing this issue!!