Bug 133541 - Image Control seems to be the wrong label for a control, which could also select all files
Summary: Image Control seems to be the wrong label for a control, which could also sel...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.4.2 release
Hardware: x86-64 (AMD64) Linux (All)
: lowest trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Form-Controls
  Show dependency treegraph
 
Reported: 2020-05-31 06:03 UTC by Robert Großkopf
Modified: 2024-11-26 16:47 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Insert Image inserts als files - not only images (50.67 KB, image/png)
2020-05-31 06:03 UTC, Robert Großkopf
Details
Example file (8.37 KB, application/vnd.oasis.opendocument.text)
2020-10-16 13:19 UTC, Buovjaga
Details
Open the database, macros enabled. Try to insert *.odt or set path to *.odt (362.92 KB, application/vnd.oasis.opendocument.database)
2024-11-26 14:03 UTC, Robert Großkopf
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Großkopf 2020-05-31 06:03:02 UTC
Created attachment 161448 [details]
Insert Image inserts als files - not only images

Don't know if UI is the right component.

See the attached screenshot for the "problem": The control for forms is named "Image Control" - but you could select all files with this control in different systems since LO 5.0. This is the only control, which could directly load any document in a database or load only the path to the file in a database. 

The "File Selection" couldn't be connected to any datasource. You have to write macros for use this control.

We shouldn't hide this feature, which is implemented in the Image Control. Shouldn't we rename it to "File Control". And shouldn't we write "Insert File" instead of "Insert Image" as title of the dialog?
Comment 1 Buovjaga 2020-10-16 13:19:53 UTC
Created attachment 166422 [details]
Example file

I don't see the problem on Linux (gtk3, kf5) or Windows.

For testers: double-click the control (while not in Form - Design mode)

Arch Linux 64-bit
Version: 7.0.1.2
Build ID: 00(Build:2)
CPU threads: 8; OS: Linux 5.8; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); Käyttöliittymä: fi-FI
=7.0.1-1
Calc: threaded
Comment 2 Xisco Faulí 2021-02-23 08:53:17 UTC
Hello Robert,
Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ?
You can install it alongside the standard version.
I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build
Comment 3 Robert Großkopf 2021-02-23 12:15:33 UTC
If I open https://bugs.documentfoundation.org/attachment.cgi?id=166422 and set a doubleclick on the control I could go to "Filter" and the first I could choose is "all files (*.*)"

If we call it "Image Control" (as it is called also in the daily build from 21-02-2021) and write in the title of the dialog "Insert Image" we are hiding a feature this control will support.

Why should this feature be hidden?
Comment 4 Buovjaga 2021-02-23 14:07:59 UTC
(In reply to Buovjaga from comment #1)
> Created attachment 166422 [details]
> Example file
> 
> I don't see the problem on Linux (gtk3, kf5) or Windows.
> 
> For testers: double-click the control (while not in Form - Design mode)

Ok, so I didn't understand that Robert had explicitly selected All files in the dialog. The default is that only images are shown.
Comment 5 QA Administrators 2023-02-24 03:23:27 UTC Comment hidden (obsolete)
Comment 6 Robert Großkopf 2023-02-24 07:22:10 UTC
Still the same: The control is called "Image control", but you could also could select other files. It would be better to show this possibility, because it is a good feature we hide at this moment.

Tested with LO 7.4.5.1 on OpenSUSE 15.3 64bit rpm Linux.
Comment 7 BogdanB 2024-11-26 12:43:24 UTC
I tried to insert an .fodt file with Insert - Image... - (All files), but then I get "Unknown image format". The same with an html file.

I think there is a lot of work behind the scene to allow just images. Buovjaga?
Comment 8 BogdanB 2024-11-26 13:41:09 UTC
Also, for the image control, I tried to insert a .cpp file - > not working. .ods file->not working. 

PDF, jpg, png files that are under image filter -> working
Comment 9 Robert Großkopf 2024-11-26 14:03:37 UTC
Created attachment 197807 [details]
Open the database, macros enabled. Try to insert *.odt or set path to *.odt

Have tried to insert *.odt-files into a database. No problem here. You couldn't see the inserted file, but you could show the content by macro. Only image-files and the first page of a pdf-file will be shown, but other files will also be saved and could also be seen by macro.
Comment 10 Robert Großkopf 2024-11-26 14:05:17 UTC
(In reply to BogdanB from comment #7)
> I tried to insert an .fodt file with Insert - Image... - (All files), but
> then I get "Unknown image format". The same with an html file.
> 
> I think there is a lot of work behind the scene to allow just images.
> Buovjaga?

You have to choose "all files", not only image files in the dialog. Then it could be loaded but isn't shown in the control. Could be shown by macro.
Comment 11 BogdanB 2024-11-26 14:35:37 UTC
Ok, nice feature in this case.
Comment 12 Buovjaga 2024-11-26 16:47:08 UTC
(In reply to BogdanB from comment #7)
> I tried to insert an .fodt file with Insert - Image... - (All files), but
> then I get "Unknown image format". The same with an html file.
> 
> I think there is a lot of work behind the scene to allow just images.
> Buovjaga?

No, this is about changing the label. However, changing it was difficult when I tried it once, so I gave up. Feel free to try.