Bug 133547 - LibODev 7.0 Beta 1 regression in PDF insert wrt image break
Summary: LibODev 7.0 Beta 1 regression in PDF insert wrt image break
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Luboš Luňák
URL:
Whiteboard: target:7.1.0 target:7.0.0.1
Keywords:
Depends on:
Blocks: PDF-Insert
  Show dependency treegraph
 
Reported: 2020-05-31 10:09 UTC by Callegar
Modified: 2020-06-01 13:55 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Callegar 2020-05-31 10:09:19 UTC
Description:
In LibODev 7 Beta 1 imported PDF images cannot be converted into an editable format by "break". The action is present in the contextual menu but does nothing.

Steps to Reproduce:
See description

Actual Results:
See description

Expected Results:
See description


Reproducible: Always


User Profile Reset: No



Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: DrawingDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes
Comment 1 V Stuart Foote 2020-05-31 16:34:14 UTC
No, when a PDF is 'imported' (i.e. Opened into Draw, or by filter into another module) it is already 'broken' into its component elements. Worth noting Justin's work done on bug 118370 for selecting multiple text box runs--so text can be consolidated into a single text box.

However, for PDF pages 'inserted' as raster images--confirm that with 7.0.0 beta 1 the .uno:Break command on the main menu Shape -> Break entry; or also on the Image context menu no longer have any action on the pdfium inserted image object.

PDF inserted as images would 'break' (for better or worse) through the 6.4 builds.


=-testing-=
Windows 10
Version: 7.0.0.0.beta1 (x64)
Build ID: 94f789cbb33335b4a511c319542c7bdc31ff3b3c
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

No different with Skia (Vulkan or raster)
Comment 2 Tomaz Vajngerl 2020-05-31 20:31:47 UTC
Should be fixed with https://gerrit.libreoffice.org/c/core/+/95227
Comment 3 Commit Notification 2020-06-01 05:17:42 UTC
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/573de30566e4477c8dc09abec08f1082d16c74bc

tdf#133547 Fix breaking of PDF graphic objects

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2020-06-01 08:08:16 UTC
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/2506d8221dd940dfd93d3d7c183430ba6ba3089d

tdf#133547 Fix breaking of PDF graphic objects

It will be available in 7.0.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.