Description: Text OK on button in Autofilter window doesn't show (macOS) Steps to Reproduce: 1. Open Calc 2. Create Autofilter 3. Open Autofilter window (click on triangle in column heading) 4. Look at OK button (see screenshot in attach) Actual Results: Text OK on button in Autofilter window doesn't show (macOS) Expected Results: I can see text OK on button in Autofilter window (macOS) Reproducible: Always User Profile Reset: No Additional Info: Version: 7.1.0.0.alpha0+ Build ID: 2047a5978ac8188e61da9cd3b2f40d86df5570bb CPU threads: 4; OS: Mac OS X 10.15.4; UI render: default; VCL: osx Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded
I see OK on button in 6.4 version => regression
Created attachment 161470 [details] Autofilter without text on OK button
Hello Roman , Thank you for reporting the bug. I can confirm that the bug is present Version: 7.0.0.0.beta1 Build ID: 94f789cbb33335b4a511c319542c7bdc31ff3b3c CPU threads: 4; OS: Mac OS X 10.15.3; UI render: default; VCL: osx Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Caolan, hi. You merged the patch https://gerrit.libreoffice.org/c/core/+/95224 . Can it fix this bug? I still see problem in today's 7.0.0.1, but not in current master. If I'm right, can you backport your patch into 7.0. Thanks
I don't see any connection from https://gerrit.libreoffice.org/c/core/+/95224 to this bug. bibisect can be used to identify commits that introduced a desirable change if you want to track down what changed things for the better
Regression introduced by: https://cgit.freedesktop.org/libreoffice/core/commit/?id=8d11b953c0a69f4f5eb5ca42dec3812a62d0cd0f author Thorsten Wagner <thorsten.wagner.4@gmail.com> 2020-02-23 21:11:05 +0100 committer Tomaž Vajngerl <quikee@gmail.com> 2020-03-06 20:36:23 +0100 commit 8d11b953c0a69f4f5eb5ca42dec3812a62d0cd0f (patch) tree 4061d4c9cd64871154a1fc843eae5cfbb6d22788 parent 4ba09be7e260ce2a79a23465db7b2837422cde30 (diff) tdf#125532: White text on default/action buttons and selected tabs on macOS Bisected with: mac64-7-0 Adding Cc: to Thorsten Wagner
Issue is present with current revision from master too. Only initial focus seems to have changed here, so moving focus with tab causes the issue too. Issue was visible during implementation of tdf#125532 already, but we decided not to fix this with the related commit. Reason was very poor code, because issue seems to be caused by an inconsistent implementation on a higher level. To sum up: There is a patch we do not want to apply. I will try to find a better and more appropriate way to fix this. BTW: Issue exists more than only at the autofiler button, e.g. on sidebar drop downs for bullets and numbers.
*** Bug 135223 has been marked as a duplicate of this bug. ***
Patch submitted to Gerrit: https://gerrit.libreoffice.org/c/core/+/99946
Thorsten Wagner committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/4b1ecab984dc46ad7dfdd8a071c94553a6c03633 tdf#133564: Text coloring of buttons within non key windows on macOS amended It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Commit Notification from comment #10) > Thorsten Wagner committed a patch related to this issue. > It has been pushed to "master": > > https://git.libreoffice.org/core/commit/ > 4b1ecab984dc46ad7dfdd8a071c94553a6c03633 > > tdf#133564: Text coloring of buttons within non key windows on macOS amended > > It will be available in 7.1.0. > > The patch should be included in the daily builds available at > https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More > information about daily builds can be found at: > https://wiki.documentfoundation.org/Testing_Daily_Builds > > Affected users are encouraged to test the fix and report feedback. Thorsten, please backport it into 7.0
verified in Version: 7.1.0.0.alpha0+ Build ID: <buildversion> CPU threads: 4; OS: Mac OS X 10.15.5; UI render: default; VCL: osx Locale: ru-RU (ru_RU.UTF-8); UI: en-US Calc: threaded Thorsten, thanks for fixing!
Unfortunately backporting to LO 7.0 is not soveld. Adolfo prepared a patch for 7.0: https://gerrit.libreoffice.org/c/core/+/99920 It seems that something has changed between 7.0 and master. While patch is successful for master (or LO 7.1), it is not working for 7.0. Investigation will take some time...
(In reply to Thorsten Wagner from comment #13) > Unfortunately backporting to LO 7.0 is not soveld. What do you mean? There was a merge conflict or the issue is not fixed in 7.0 ?
Issue is fixed in 7.1 only, not for 7.0 - it seems, that something has changed here between 7.0 and 7.1. It would be very nice to have someone to verify this on macOS. Maybe it is my build environment but I do not beleave so.
(In reply to Thorsten Wagner from comment #15) > Issue is fixed in 7.1 only, not for 7.0 - it seems, that something has > changed here between 7.0 and 7.1. Sure, the issue is fixed in LibreOffice 7.1 because your patch was submitted to master ( 7.1 ). it will be fixed in 7.0 once the backport it submitted
Only to avoid missunderstandings: Patch has the desired result with LO 7.1 (already submitted to master) and has NOT the desired result with LO 7.0 - so, work on a backport is still in progress but not finished.
Published backport to Gerrit: https://gerrit.libreoffice.org/c/core/+/99920
Thorsten Wagner committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/7e7af0658d9c769d9e5b3614e5f3fef3187ea833 tdf#133564: Text coloring of buttons within non key windows on macOS reworked It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Thorsten Wagner committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/cb8bf2cea598b48783e2d7d60ef711ec438719a4 tdf#133564: Text coloring of buttons within non key windows on macOS amended It will be available in 7.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.