Bug 133602 - FILESAVE: DOCX: Incorrect position of OLE object after RT
Summary: FILESAVE: DOCX: Incorrect position of OLE object after RT
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Attila Bakos (NISZ)
URL:
Whiteboard: target:7.1.0 target:7.0.0.1
Keywords: bibisected, bisected, filter:docx, regression
Depends on:
Blocks:
 
Reported: 2020-06-02 14:10 UTC by Xisco Faulí
Modified: 2020-06-16 11:30 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Comparison MSO 2010 and LibreOffice 7.0 master after RT (157.63 KB, image/png)
2020-06-02 14:10 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Xisco Faulí 2020-06-02 14:10:34 UTC
Created attachment 161526 [details]
Comparison MSO 2010 and LibreOffice 7.0 master after RT

Steps to reproduce:
1. Open attachment 42590 [details] from bug 33590
2. Save it .DOCX
3. Open the new generated file

-> The OLE object at the bottom is overlapping the text above it. See comparison

Reproduced in

Version: 7.0.0.0.alpha1+
Build ID: 82894d85147840f1f587e9530b12f0058f2ef2c3
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded


[Bug found by office-interoperability-tools]
Comment 1 Xisco Faulí 2020-06-02 14:11:42 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=2150fdc7d0f63288ac56c33cb898589512057642

author	Attila Bakos <bakos.attilakaroly@nisz.hu>	2020-04-09 17:10:22 +0200
committer	László Németh <nemeth@numbertext.org>	2020-04-28 10:18:08 +0200
commit 2150fdc7d0f63288ac56c33cb898589512057642 (patch)
tree a7f6c1fbc6050b13b8950880c4a1ad02c1e71c21
parent c431661ac716178305f64d98ce81aa8276bdbe8f (diff)
tdf#131539 DOCX export: fix position of OLE objects

Bisected with: bibisect-linux64-6.

Adding Cc: to Attila Bakos
Comment 2 Xisco Faulí 2020-06-02 14:14:01 UTC
attachment 45771 [details] from bug 34619 is also affected by this issue
Comment 3 Xisco Faulí 2020-06-02 15:16:17 UTC
attachment 63596 [details] from bug 51550 is also affected
Comment 4 Commit Notification 2020-06-10 09:13:31 UTC
Attila Bakos committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4bdff3c731a9f8ef11ffdae804a99a47f119ee50

tdf#133065 tdf#133602 DOCX export: fix OLE wrap regression

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2020-06-16 11:29:51 UTC
Verified in

Version: 7.1.0.0.alpha0+
Build ID: 11d21b3c1f7754b5d13ae9ea88da562ec74366ff
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Attila Bakos, thanks for fixing this issue!!
Comment 6 Commit Notification 2020-06-16 11:30:59 UTC
Attila Bakos committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/e0ba88a08c9c16fd805e13956ac9676f4ddfd377

tdf#133065 tdf#133602 DOCX export: fix OLE wrap regression

It will be available in 7.0.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.