Bug 133780 - Sort in search result no not work
Summary: Sort in search result no not work
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.3.0.4 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.1.0 target:7.0.0.1 target:6.4.6
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Find&Replace-Dialog
  Show dependency treegraph
 
Reported: 2020-06-08 07:00 UTC by Devamitta
Modified: 2020-06-16 16:00 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
search result window (19.39 KB, image/png)
2020-06-08 07:00 UTC, Devamitta
Details
the arrow missing (45.25 KB, image/png)
2020-06-08 18:48 UTC, BogdanB
Details
a file to test the bug (9.16 KB, application/vnd.oasis.opendocument.spreadsheet)
2020-06-08 18:52 UTC, BogdanB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Devamitta 2020-06-08 07:00:37 UTC
Created attachment 161750 [details]
search result window

Before, in  6.1.4, when I search something using CTRL + F in window what showed search result I can sort by Cell or by Content. But now this function disappear. Will be very useful to have this function back.
Comment 1 BogdanB 2020-06-08 18:47:48 UTC
Confirm, there was an arrow to sort the column.

See image the black arrow.

I tested in Version: 5.4.7.2 - WAS AVAILABLE
Build ID: c838ef25c16710f8838b1faec480ebba495259d0
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk2; 
Locale: ro-RO (ro_RO.UTF-8); Calc: group

In Version: 6.3.1.2 IT IS NOT AVAILABLE ANY MORE.
Build ID: b79626edf0065ac373bd1df5c28bd630b4424273
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; 
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded

Maybe like Devamitta says it is not available yet in 6.1.4.
Comment 2 BogdanB 2020-06-08 18:48:21 UTC
Created attachment 161776 [details]
the arrow missing

the black arrow missing
Comment 3 BogdanB 2020-06-08 18:50:43 UTC
Steps to reproduce for this regression

- Open my test-sort file and press CTRL+F to search for number 3.
- Click on Find all.
- in the Search Result window click on Cell line to show the arrow.

- The arrow is not there
- In fact the arrow should appear.
Comment 4 BogdanB 2020-06-08 18:52:14 UTC
Created attachment 161777 [details]
a file to test the bug

Try to search for number 3
Comment 5 Aron Budea 2020-06-08 19:50:23 UTC
Bibisected to the following commit using repo bibisect-linux-64-6.3. Not sure what the possibilities are, nevertheless, adding CC: to Caolán McNamara.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=cd19a7664a25eda786bb76feefb40ebcbf79a54d
author		Caolán McNamara <caolanm@redhat.com>	2019-03-26 14:12:49 +0000
committer	Caolán McNamara <caolanm@redhat.com>	2019-03-26 18:23:23 +0100

weld SearchResultsDlg
Comment 6 Commit Notification 2020-06-09 11:31:39 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/066d70da9391b43e9586736812b1064028aa53fc

Resolves: tdf#133780 allow sorting search result treeview columns

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2020-06-09 19:44:49 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/79bf8179aaf7bdaef59b27e65bf0430db9aff168

Resolves: tdf#133780 allow sorting search result treeview columns

It will be available in 7.0.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Caolán McNamara 2020-06-09 19:45:20 UTC
fixed in master and 7-0, backport to 6-4 in gerrit
Comment 9 BogdanB 2020-06-13 18:53:14 UTC
It's ok now.

Verified in
Version: 7.1.0.0.alpha0+
Build ID: cd47dba9aa4b91bb0edf0744561d29e2eef61cc9
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-06-11_19:46:20
Calc: threaded
Comment 10 BogdanB 2020-06-13 18:53:20 UTC Comment hidden (obsolete)
Comment 11 Commit Notification 2020-06-16 16:00:09 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/e8a4fae1cdc2373bfb1fd9e5f8ac55499f58f9a5

Resolves: tdf#133780 allow sorting search result treeview columns

It will be available in 6.4.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.