Created attachment 162078 [details] Sample PPTX document In the sample document, shadows appear blurry in Office 365 and solid in LibreOffice 7.1alpha1 (and 6.4.4.2). Note 1: This is not about the blurry edges feature, which would affect the primary shape (= rectangles here), but blurrying the shadows. Note 2: The sample document has two slides exhibiting the same issue.
Created attachment 162079 [details] How it looks in LibreOffice (hard shadows)
Created attachment 162080 [details] This is how it looks in Office 365 (soft shadows)
I can't reproduce it in Version: 7.1.0.0.alpha0+ Build ID: 11d21b3c1f7754b5d13ae9ea88da562ec74366ff CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded Could you please try to reproduce it with a master build from http://dev-builds.libreoffice.org/daily/master/ ? You can install it alongside the standard version. I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the master build
(In reply to Xisco Faulí from comment #3) > I can't reproduce it in > > Version: 7.1.0.0.alpha0+ > Build ID: 11d21b3c1f7754b5d13ae9ea88da562ec74366ff > CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 > Locale: en-US (en_US.UTF-8); UI: en-US > Calc: threaded > > Could you please try to reproduce it with a master build from > http://dev-builds.libreoffice.org/daily/master/ ? > You can install it alongside the standard version. > I have set the bug's status to 'NEEDINFO'. Please change it back to > 'UNCONFIRMED' if the bug is still present in the master build The screenshot I shared for LibreOffice was taken with Version: 7.1.0.0.alpha0+ Build ID: cd47dba9aa4b91bb0edf0744561d29e2eef61cc9 CPU threads: 4; OS: Linux 5.6; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-06-11_19:46:20 Calc: threaded and I re-confirmed it really looks that way with that. I found there is a build dated 2020-06-15 now (four days newer) and will give that a try.
Indeed, it was wrong 4 days ago and it was fixed by https://cgit.freedesktop.org/libreoffice/core/commit/?id=b435c4fe82e77a82fde6464d6722281e5fc4f394
@A_GAN, any chance you could created a unittest for this issue you fixed ?
The pptx file I made in MS PowerPoint with a blurry shadow and used it for testing the import of the blur radius. I've already made a unit test for importing the radius here: https://opengrok.libreoffice.org/xref/core/sd/qa/unit/import-tests.cxx?r=88a5f776#3124 to check that I've got it correct but not available to be seen yet. Then Later I've created process function which is responsible to create the blurring effect on the shadow of the shape and view it. Here's the function that resolved the bug: https://opengrok.libreoffice.org/xref/core/drawinglayer/source/processor2d/vclpixelprocessor2d.cxx?r=b435c4fe#1077 Now, it's available to see the blurring shadow as part of my GSoC project
(In reply to Xisco Faulí from comment #5) > Indeed, it was wrong 4 days ago and it was fixed by > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=b435c4fe82e77a82fde6464d6722281e5fc4f394 Yep, confirmed now on the same system, after another update. Version: 7.1.0.0.alpha0+ Build ID: a3c8ea5e644ca2fc04de9f01ba9f8ace47f520f0 TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-06-17_02:21:20
Oh, wait! This has been addressed in edit mode only. In presentation mode it still looks like the attached screenshot labeled "How it looks in LibreOffice (hard shadows)". Reopening this bug report.
(In reply to ahmad_g from comment #7) > The pptx file I made in MS PowerPoint with a blurry shadow and used it for > testing the import of the blur radius. > > I've already made a unit test for importing the radius here: > https://opengrok.libreoffice.org/xref/core/sd/qa/unit/import-tests. > cxx?r=88a5f776#3124 > > to check that I've got it correct but not available to be seen yet. > > Then Later I've created process function which is responsible to create the > blurring effect on the shadow of the shape and view it. > > Here's the function that resolved the bug: > https://opengrok.libreoffice.org/xref/core/drawinglayer/source/processor2d/ > vclpixelprocessor2d.cxx?r=b435c4fe#1077 > > Now, it's available to see the blurring shadow as part of my GSoC project Hello ahmad, thanks for the great work here! I believe https://cgit.freedesktop.org/libreoffice/core/commit/?id=b435c4fe82e77a82fde6464d6722281e5fc4f394 was submitted right after your wrote those unittests, thus there's no unittest covering this issue, isn't it ?
(In reply to Xisco Faulí from comment #10) > (In reply to ahmad_g from comment #7) > > The pptx file I made in MS PowerPoint with a blurry shadow and used it for > > testing the import of the blur radius. > > > > I've already made a unit test for importing the radius here: > > https://opengrok.libreoffice.org/xref/core/sd/qa/unit/import-tests. > > cxx?r=88a5f776#3124 > > > > to check that I've got it correct but not available to be seen yet. > > > > Then Later I've created process function which is responsible to create the > > blurring effect on the shadow of the shape and view it. > > > > Here's the function that resolved the bug: > > https://opengrok.libreoffice.org/xref/core/drawinglayer/source/processor2d/ > > vclpixelprocessor2d.cxx?r=b435c4fe#1077 > > > > Now, it's available to see the blurring shadow as part of my GSoC project > > Hello ahmad, thanks for the great work here! Thank you! > I believe > https://cgit.freedesktop.org/libreoffice/core/commit/ > ?id=b435c4fe82e77a82fde6464d6722281e5fc4f394 was submitted right after your > wrote those unittests, thus there's no unittest covering this issue, isn't > it ? Yes, the process function was submitted after the import unit test. I am still working on the blurring of the shadow. What kind of unit test that covers this issue?
(In reply to Gerald Pfeifer from comment #9) > Oh, wait! This has been addressed in edit mode only. > > In presentation mode it still looks like the attached screenshot labeled > "How it looks in LibreOffice (hard shadows)". Reopening this bug report. Ahmad, do you have an outlook on when/whether you will be able to address this? That would be awesome, thank you!
(In reply to Gerald Pfeifer from comment #12) > (In reply to Gerald Pfeifer from comment #9) > > Oh, wait! This has been addressed in edit mode only. > > > > In presentation mode it still looks like the attached screenshot labeled > > "How it looks in LibreOffice (hard shadows)". Reopening this bug report. > > Ahmad, do you have an outlook on when/whether you will be able to address > this? That would be awesome, thank you! It could be supported but the transparency of the blurred shadow will be having some problems in presentation mode. I am trying to figure it out but still stuck in it.
Hi Mike, you reviewed the original patch that added this in edit mode. Do you maybe have an idea/hint how to also make this work in presentation mode? Thanks!
A_GAN committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b6e508fc47ecb3650fd82c5e174e6d6a084e9ec6 tdf#134052:shadow appears solid instead of blurry in presentation mode It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
I am happy to confirm this is fixed for me with current 7.1 builds - thank you! Are you going to also push this back into the 7.0 tree?
(In reply to Gerald Pfeifer from comment #16) > I am happy to confirm this is fixed for me with current 7.1 builds > - thank you! > > Are you going to also push this back into the 7.0 tree? This is part of the GSOC project 'Blurry Shadows', see https://ahmadganzouri.blogspot.com/2020/08/gsoc-2020-final-report.html#more You will have to wait for LibreOffice 7.1
Verified in Version: 7.1.0.0.alpha0+ Build ID: e2f4e65a7b8024c00b049eebf0d87637efda7f24 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Ahmad, thanks for fixing this issue!