Download it now!
Bug 134291 - Names of new hatch patterns in 7.0 not localizable
Summary: Names of new hatch patterns in 7.0 not localizable
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Localization (show other bugs)
Version:
(earliest affected)
7.0.0.0.beta1+
Hardware: All All
: highest normal
Assignee: Julien Nabet
URL:
Whiteboard: target:7.1.0 target:7.0.0.1
Keywords:
Depends on:
Blocks: Not-Localizable
  Show dependency treegraph
 
Reported: 2020-06-25 04:24 UTC by Ming Hua
Modified: 2020-07-19 07:47 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Hua 2020-06-25 04:24:03 UTC
Version 7.0 introduced a new set of hatch patterns in Writer's (maybe available in other modules as well? I didn't check) Format > Page Style > Area > Hatch, but the names of the patterns (shown when mouse cursor is hovered over the patterns) are not properly prepared for localization.  For example, the "Blue 45 Degrees" name (first pattern in the second row) has no KeyID, and has no hit in Weblate.

I'm not familiar with the code base and can only track down the strings to file core/extras/source/palettes/standard.soh:
https://opengrok.libreoffice.org/xref/core/extras/source/palettes/standard.soh?r=30a6e9e9

Tested with TDF official 7.0.0 Beta2 build on Windows 10, however it seems there is no easy way to copy the version information in Beta2.
Comment 1 Julien Nabet 2020-06-25 07:19:36 UTC
Andreas: noticing
https://cgit.freedesktop.org/libreoffice/core/commit/?id=30a6e9e991fd1b62ead2d393331a0364372c52fb
"tdf#130928 Area Fill update hatcch section"
thought you might be interested in this one.
Comment 2 Julien Nabet 2020-06-25 07:21:13 UTC
string freeze is very near (see https://wiki.documentfoundation.org/ReleasePlan/7.0)
quite urgent then.
Comment 4 Julien Nabet 2020-06-25 07:26:24 UTC
another code pointer:
https://opengrok.libreoffice.org/xref/core/svx/source/unodraw/unoprov.cxx?r=59523318#1527
RID_SVXSTR_HATCHS_DEF[] and RID_SVXSTR_HATCHS[] should be adapted
I'm not sure but I think we must be cautious about the order.
Comment 5 Julien Nabet 2020-06-25 08:29:48 UTC
I'll give it a try.
Comment 6 Julien Nabet 2020-06-25 08:54:33 UTC
https://gerrit.libreoffice.org/c/core/+/97093
Comment 7 Commit Notification 2020-06-25 10:08:48 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/52d70047c694d4e0c8bbf843c895d86492735f3f

tdf#134291: make all hatch patterns translatable

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Julien Nabet 2020-06-25 10:10:47 UTC
Patch waiting for review in 7.0 branch:
https://gerrit.libreoffice.org/c/core/+/97064
Comment 9 Commit Notification 2020-06-25 11:07:20 UTC
Julien Nabet committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/587d75bc5bcd308168bc30567ab45b08e1ae062c

tdf#134291: make all hatch patterns translatable

It will be available in 7.0.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Ming Hua 2020-07-19 07:47:43 UTC
Verified in 7.0.0 RC2:
Version: 7.0.0.2 (x64)
Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c
CPU 线程: 2; 操作系统: Windows 10.0 Build 18363; 界面渲染: Skia/点阵; VCL: win
Locale: zh-CN (zh_CN); 界面: zh-CN
Calc: threaded

Thanks Julien!