Bug 134377 - Unoperating Help buttons in File/Open|Save|Save As|Save Remote libO dialogs
Summary: Unoperating Help buttons in File/Open|Save|Save As|Save Remote libO dialogs
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
5.2 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.1.0 target:7.5.0 target:7.6....
Keywords:
Depends on: 159111
Blocks:
  Show dependency treegraph
 
Reported: 2020-06-29 06:27 UTC by Alain Romedenne
Modified: 2024-02-26 11:48 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alain Romedenne 2020-06-29 06:27:31 UTC
online/offline help pages not opening any longer when pressing help button in the following 'LibreOffice dialogs':

-File/Open
-File/Save
-File/Save As
-File/Save Remote

… affects FilePicker/FolderPicker API as well
Comment 1 Alain Romedenne 2020-06-29 07:56:42 UTC
You may use Tools-Options-LibreOffice-General-Open/Save Dlg boxes to enforce the display of affected dialogs.


File/Open
File/Open Remote
   should link to text/shared/guide/doc_open.xhp
File/Save
File/Save Remote
   should link to text/shared/01/01060001.xhp
or                text/shared/guide/cmis-remote-files.xhp

I assume that FilePicker and FolderPicker services would link the same pages

Note: The Help button of Manage services subsequent dialog is also faulty

Assigned Documentation team in order to verify suggested target help pages
Comment 2 Buovjaga 2020-08-05 09:12:19 UTC
File/Open (or Save) Remote link me to text/shared/guide/cmis-remote-files.html

The others indeed don't work, if I activate LibO dialogs in Tools-Options-LibreOffice-General-Open/Save Dialogs

Arch Linux 64-bit
Version: 7.1.0.0.alpha0+
Build ID: 94811eac3bd3077b60029c52d7798bca9b3c877b
CPU threads: 8; OS: Linux 5.7; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 2 August 2020
Comment 3 Alain Romedenne 2020-08-05 12:45:05 UTC
Links are missing from 5.2.x onwards and probably before
Comment 4 Commit Notification 2020-08-05 21:10:17 UTC
Alain Romedenne committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/c662efdb61d7f5b2cb0a000679761de16598c3d1

tdf134377 Missing topic in TOC
Comment 5 Alain Romedenne 2020-08-07 13:30:51 UTC
Associated dialogs are

 - File / …
   /core/fpicker/uiconfig/ui/explorerfiledialog.ui 
 - File / … Remote
   /core/fpicker/uiconfig/ui/remotefilesdialog.ui

File / Open Remote and File / Save Remote dialog is linked to text/shared/guide/cmis-remote-files.html help page from 6.x onwards

A 'Opening and Saving (local) files' generic help page is necessary for FilePicker dialogs. It should link to existing LO menus and LO toolbars help pages
Comment 6 Olivier Hallot 2020-08-07 18:58:10 UTC
Agree to refactor the Open and Save Help pages.
Comment 7 Olivier Hallot 2020-08-07 19:11:29 UTC
the file picker hid's are in the form

Help ID: fps/ui/explorerfiledialog/file_name
Help ID: fps/ui/explorerfiledialog/file_type
etc.

so the bookmark is like
<bookmark branch="hid/fps/ui/explorerfiledialog/file_name" id="(...)" localize="false"/>

widgets are to be obtained from Glade loaded with fpicker/.../explorefiledialog.ui

Is some situations you also have Helpid in the form

Help ID: SVT_HID_FILESAVE_FILEURL
Help ID: SVT_HID_FILESAVE_FILEVIEW
Comment 8 Alain Romedenne 2022-09-09 14:30:26 UTC
I am confused, many menus lead to use:
   /core/fpicker/uiconfig/ui/explorerfiledialog.ui 

To name a few:
   File - Open
   File - Save as…
   Insert - Text from document
   including multiple variations of Import/Export

Planning separate pages for each 'use case' implies to define identical hid's in different .xhp as common features will be present in different .xhp. Can you provide writing guidances or examples?

Or am I suggesting something wrong?
Comment 9 Alain Romedenne 2022-09-09 14:41:36 UTC
https://opengrok.libreoffice.org/xref/help/source/text/shared/01/01020000.xhp
seems to be the supporting help pages that's not shown when pressing F1

Should this page be 
 - corrected and aggregate all 'use cases' ?
 - copied over - one or many - page(s) and then deleted?
Comment 10 Commit Notification 2022-11-30 15:29:58 UTC
Alain Romedenne committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/23d4609281bf48afe6b343897900ae0c5b3d3ff7

tdf134377 Refactoring a few help pages for 'built-in' file dialogs …
Comment 11 Commit Notification 2022-12-02 16:25:17 UTC
Alain Romedenne committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/d700f1fe9e6e265d0f0125a0fb734fb2c201ce1a

tdf#134377 Refactoring built-in file dialogs
Comment 12 Commit Notification 2022-12-08 15:24:36 UTC
Alain Romedenne committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/9cd78ba1f7b77ed8a062906f2e553a4dbfca6ea4

tdf#134377 fix faulty embed tags in help
Comment 13 Commit Notification 2022-12-13 13:43:42 UTC
Alain Romedenne committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/551e891308a664f5c17613d381044381e2d92bb0

tdf#134377 Refactoring a few help pages for 'built-in' file dialogs …
Comment 14 Commit Notification 2022-12-16 12:53:46 UTC
Alain Romedenne committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/e90036912468f58be544b2f12dec0adc7ae8036e

tdf#134377 Refactoring more help pages for 'built-in' file dialogs …
Comment 15 Commit Notification 2022-12-16 16:28:13 UTC
Alain Romedenne committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/55f43cd2900eb670bce537a939ea0f435439d926

tdf#134377 Help page not found when clicking 'Help' button
Comment 16 Justin L 2023-06-17 10:52:24 UTC
Please mark as "fixed" if this task is completed, or else clarify why it needs to remain open.
Comment 17 Alain Romedenne 2024-02-08 14:27:04 UTC
Other help pages may benefit from text sharing and text enrichments
Comment 18 Commit Notification 2024-02-24 16:39:55 UTC
Olivier Hallot committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/help/commit/62cfd5d6512a99cfa88a558d74b3bb335315e1ee

tdf#134377 Fix bookmark in native file explorer dialog