Bug 134478 - It would be nice if the log file path specified in EditDbg::ShowEditEngineData can be dynamically specified (e.g. through envvars) without recompiling
Summary: It would be nice if the log file path specified in EditDbg::ShowEditEngineDat...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard: target:7.1.0
Keywords:
Depends on:
Blocks: Dev-related
  Show dependency treegraph
 
Reported: 2020-07-03 12:44 UTC by himajin100000
Modified: 2023-10-03 18:33 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
editenginedump.log when the crash happened. (4.11 KB, text/plain)
2020-07-18 17:49 UTC, himajin100000
Details

Note You need to log in before you can comment on or make changes to this bug.
Description himajin100000 2020-07-03 12:44:21 UTC
Description:
https://opengrok.libreoffice.org/xref/core/editeng/source/editeng/editdbg.cxx?r=1138adc1&fi=ShowEditEngineData#324

I still haven't run into such a situation, though.

Steps to Reproduce:
N/A

Actual Results:
d:\\debug.log is used for dumping 

Expected Results:
we can choose what file we use for dumping 


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 7dc3a20cab712ee987ea25a8f5728529521485b7
CPU threads: 4; OS:Windows 10.0 Build 18363; UI render: default; VCL: win
Locale: ja-JP (ja_JP); UI: ja-JP
Calc: CL
Comment 1 Jan-Marek Glogowski 2020-07-03 15:23:27 UTC
Honestly, it shouldn't be a path at all. And a better name. All other log facilities I'm aware of, like the Writer layout and document note dumps, simply write a fixed file to the working directory of LO.

My proposal is https://gerrit.libreoffice.org/c/core/+/97873
Comment 2 Commit Notification 2020-07-14 14:21:05 UTC
Jan-Marek Glogowski committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a03bc509cd19011043c340b893e7b00c7937423c

tdf#134478 Refactor dumping of EditEngine data

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 himajin100000 2020-07-18 17:49:03 UTC
Created attachment 163245 [details]
editenginedump.log when the crash happened.
Comment 4 himajin100000 2020-07-18 17:51:46 UTC
I've just made my own local build.

LibreOffice crashed when I tested the fix from Calc's Default Page Style->[Header] Tab->[Edit] Button with the following assert. Does this happen on your environment?

---------------------------
Microsoft Visual C++ Runtime Library
---------------------------
Debug Assertion Failed!

Program: C:\build\instdir\program\mergedlo.dll
File: C:\PROGRA~2\MIB055~1\2019\Preview\VC\Tools\MSVC\14.27.29016\Include\vector
Line: 1369

Expression: vector erase iterator outside range

For information on how your program can cause an assertion
failure, see the Visual C++ documentation on asserts.

(Press Retry to debug the application)