Bug 134491 - Calc UI: icons of "Text Extension" radio buttons broken in Calc>Sidebar>Alignment (Regression to 6.4.4)
Summary: Calc UI: icons of "Text Extension" radio buttons broken in Calc>Sidebar>Align...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.0.0.0.beta1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.1.0 target:7.0.2
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Sidebar-Properties
  Show dependency treegraph
 
Reported: 2020-07-04 04:53 UTC by Mike
Modified: 2021-12-16 10:13 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
134491 - Icons of all radio buttons activated (blue line) (9.99 KB, image/png)
2020-07-09 17:58 UTC, Mike
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike 2020-07-04 04:53:29 UTC
Description:
In the sidebar of Calc are radio buttons for "Text Extension". If you click on one of their icons, the other two icons must change to "off" status. But you can enable all three (visually) and can't switch those icons "off".

Steps to Reproduce:
1. Open Calc in a LO 7 pre-release
2. Open Sidebar
3. Click on the 3 icons in "Alignment"
"Text Extension from Lower Cell Border"
"Text Extension from Upper Cell Border"
"Text Extension inside Cell"

Actual Results:
Those icons represent radio buttons. If you click on one icon, the other two icons must change to "off" status. But you can enable all three (visually) and can't switch those icons "off".

Expected Results:
I click on one button. Its icon changes to "on" state and the other buttons to "off" state.



Reproducible: Always


User Profile Reset: No



Additional Info:

This is a regression.
The icons are working in 6.4.4 and are broken in LO7B1<.

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 7dc3a20cab712ee987ea25a8f5728529521485b7
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-US
Calc: threaded

Version: 6.4.4.2 (x64)
Build-ID: 3d775be2011f3886db32dfd395a6a6d1ca2630ff
CPU-Threads: 4; BS: Windows 10.0 Build 18363; UI-Render: GL; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: CL
Comment 1 Mike 2020-07-09 17:58:49 UTC
Created attachment 162856 [details]
134491 - Icons of all radio buttons activated (blue line)
Comment 2 Xisco Faulí 2020-07-10 16:50:00 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=77bba5b6b9f12fc0970918f5073c52775a48603c

author	andreas kainz <kainz.a@gmail.com>	2020-01-18 13:48:01 +0100
committer	andreas_kainz <kainz.a@gmail.com>	2020-01-20 22:36:02 +0100
commit 77bba5b6b9f12fc0970918f5073c52775a48603c (patch)
tree 5938d7d1cb276eb76820581fe2c48ebf567437de
parent 0453eb32b9055fe27fcb7b9cef22c46d32e59196 (diff)
calc sidebar alignment update

Bisected with: bibisect-linux64-7.0

Adding Cc: to andreas kainz
Comment 3 andreas_k 2020-08-28 21:33:42 UTC
Thanks for reporting this bug Mike. Will fix it asap
Comment 4 Commit Notification 2020-08-29 20:11:55 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/977a97f3148c0aece0a54304aae81ec44ced07e0

tdf#134491 Calc sidebar alignment fix

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Heiko Tietze 2020-08-31 07:11:32 UTC
(In reply to Commit Notification from comment #4)
> andreas kainz committed a patch

Resolve fixed?
Comment 6 andreas_k 2020-08-31 07:18:17 UTC
backport to 7.0 and maybe to 6.4.x is in gerrigt.
Comment 7 Commit Notification 2020-09-01 17:18:37 UTC
andreas kainz committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/39585d37e31de0754d6d66c9c5338ae9429b83c7

tdf#134491 Calc sidebar alignment fix

It will be available in 7.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Gabor Kelemen (allotropia) 2021-12-16 10:13:33 UTC
Seems like this was forgotten to set as closed.