Bug 134734 - Implement attribute draw:background-size completely
Summary: Implement attribute draw:background-size completely
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: x86-64 (AMD64) Windows (All)
: medium enhancement
Assignee: Michael Stahl (allotropia)
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-11 17:15 UTC by Regina Henschel
Modified: 2021-03-25 11:29 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Regina Henschel 2020-07-11 17:15:36 UTC
ODF 1.3 allows <style:drawing-page-properties> for all kind of master-pages and pages, not only for Draw/Impress but for Writer and Calc too.
This element has an attribute draw:background-size with values "border" and "full" to determine whether the background fills only the area between the border lines or the entire page.

LO 7.0 writes the attribute with the value that corresponds to its current rendering ("full" in Writer and "border" in Draw/Impress). But LO 7.0 is not able to render it the other way and has no UI to set the value.

Additional problems:
If a text document, which has background rendered as if it was "border" in older versions, is opened in LO 7.0, the background is rendered as "full". So the document looks different.

Using the fill properties from <style:drawing-page-properties> is currently not implemented for Calc.
Comment 1 Xisco Faulí 2020-09-07 10:03:41 UTC
Moving to NEW
Comment 2 Michael Stahl (allotropia) 2021-03-17 13:53:01 UTC
in Writer, the bitmap background behaves oddly - its "origin" is always the top-left of the page body, regardless of what the paint area is... the other ones adapt to their paint area automatically.

so with "Tiled" in the UI a tile starts in the top-left of the body, and to its left and top partial tiles are painted; use "Stretch" in the UI and it scales to the page body regardless of the setting.

i'm assuming this should be fixed to use the full page top-left as origin?

hmm... Word apparently can't do anything else than Tiled with the page top-left as origin so i guess it should look like that.
Comment 3 Commit Notification 2021-03-25 08:50:35 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/56d8007a197b095b09423c691a51515567648e80

tdf#134734 tdf#141059 tdf#122508 cui,sw,xmloff: BackgroundFullSize

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2021-03-25 08:55:05 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e9c6fd6b4d09ee59b6a86942cbf001f2ba9782e6

tdf#134734 xmloff: ODF import compatibility for BackgroundFullSize

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2021-03-25 10:13:02 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dda83832529fd8c7d02bdf14890faf84a3512112

tdf#134734 svx,sd: BackgroundFullSize

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2021-03-25 11:12:36 UTC
Michael Stahl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/8a859cdecdd49e186b95a051ee31756770d50e9c

tdf#134734 sd,sw: add UITests

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Michael Stahl (allotropia) 2021-03-25 11:29:47 UTC
fixed on master.

Impress has the oddity that the Slide->Properties dialog applies page margins and this fullsize flag to all master pages.