Description: FILESAVE DOCX: Error The file could not be written. Steps to Reproduce: 1. Open attachment 163360 [details] 2. Hide tracking changes (if visible) 3. Delete page 2-22 by select and pressing backspace 4. Save -> Will crash currently bug 135014 not in 6.3 5. Press Undo 6. Save again Actual Results: Error The file could not be written. Expected Results: No error Reproducible: Always User Profile Reset: No Additional Info: Found in 6.3 and in Version: 6.0.5.0.0+ Build ID: 15ea1cda0b3c37ff944ad9a239b7ed453e8b0591 CPU threads: 4; OS: Windows 6.3; UI render: default; Locale: nl-NL (nl_NL); Calc: CL
Created attachment 163545 [details] Example file Smaller file 1. Open attachement 2. Go to page 7 3. Delete image/incl frame by placing cursor left & pressing backspace 4. Press Undo 5. Press Save -> Error 6. Change to ODT -> Saving 7. File reload -> Images gone
Created attachment 163546 [details] Example file
No repro with Version: 4.3.7.2 Build ID: 8a35821d8636a03b8bf4e15b48f59794652c68ba
Created attachment 163547 [details] Bibisect log Bisected to: commit d379d18666aa42031359ca8eb34b0021960347ae Author: Miklos Vajna <vmiklos@collabora.co.uk> AuthorDate: Wed Jun 18 11:57:31 2014 +0200 Commit: Miklos Vajna <vmiklos@collabora.co.uk> CommitDate: Wed Jun 18 12:09:15 2014 +0200 oox: import WPS shape with text as shape with textbox This allows having real shapes (like having rounded corners) and complex content (like containing a table) at the same time. WPS shapes are wrappers around drawingML markup in DOCX files, so this only affects the DOCX import.
*** Bug 135149 has been marked as a duplicate of this bug. ***
Created attachment 163686 [details] Additional Example file 1. Open the attached file 2. CTRL+A 3. CTRL+X 4. Undo 5. press save -> Failure
@Xisco, If have some time to (un)confirm.. Not a big fan of write errors. OTOH, around for a quite some time now..
Reproduced in Version: 7.1.0.0.alpha0+ Build ID: 76c40b82e6a44539cd43f326c00246e759449571 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
Created attachment 163978 [details] minimal reproducer
(In reply to Telesto from comment #4) > Created attachment 163547 [details] > Bibisect log > > Bisected to: > commit d379d18666aa42031359ca8eb34b0021960347ae > Author: Miklos Vajna <vmiklos@collabora.co.uk> > AuthorDate: Wed Jun 18 11:57:31 2014 +0200 > Commit: Miklos Vajna <vmiklos@collabora.co.uk> > CommitDate: Wed Jun 18 12:09:15 2014 +0200 > > oox: import WPS shape with text as shape with textbox > > This allows having real shapes (like having rounded corners) and > complex > content (like containing a table) at the same time. > > WPS shapes are wrappers around drawingML markup in DOCX files, so > this > only affects the DOCX import. Not sure if the bisection is correct. 1. the mentioned commit fixes an import issue. The problem described in this bug is an export issue 2. Before the mentioned commit, LibreOffice crashes cutting the content, so no possible to test all the steps (cut, undo, save)
(In reply to Xisco Faulí from comment #10) > (In reply to Telesto from comment #4) > > Created attachment 163547 [details] > > Bibisect log > > > > Bisected to: > > commit d379d18666aa42031359ca8eb34b0021960347ae > > Author: Miklos Vajna <vmiklos@collabora.co.uk> > > AuthorDate: Wed Jun 18 11:57:31 2014 +0200 > > Commit: Miklos Vajna <vmiklos@collabora.co.uk> > > CommitDate: Wed Jun 18 12:09:15 2014 +0200 > > > > oox: import WPS shape with text as shape with textbox > > > > This allows having real shapes (like having rounded corners) and > > complex > > content (like containing a table) at the same time. > > > > WPS shapes are wrappers around drawingML markup in DOCX files, so > > this > > only affects the DOCX import. > > Not sure if the bisection is correct. > 1. the mentioned commit fixes an import issue. The problem described in this > bug is an export issue > 2. Before the mentioned commit, LibreOffice crashes cutting the content, so > no possible to test all the steps (cut, undo, save) It's quite possible i'm wrong.. don't remember how I did the bibisect
ok, so I've reverted d379d18666aa42031359ca8eb34b0021960347ae locally and now LibreOffice claims the document might be corrupted at import time. If I ignore the error and open the document, then I can cut the content, undo and save. I believe this might no be a regression, but just an existing problem that became more visible after d379d18666aa42031359ca8eb34b0021960347ae, anyway, adding Miklos to the loop to hear from the expert. Adding Cc: to Miklos Vajna
Created attachment 164049 [details] Example file Maybe even simpler 1. CTRL+A 2. CTRL+X 3. CTRL+Z 4. Press Save -> Error 5. Work around attempt -> Save As ODT & File reload -> Invisible frames
Created attachment 164283 [details] Additional Example file Not much different, so likely irrelevant but anyway 1. Open the attached file 2. Save as DOCX 3. File reload 4. Select the figure 1 frame 5. CTRL+X 6. CTRL+Z 7. Save
(In reply to Telesto from comment #13) > Maybe even simpler > > 1. CTRL+A > 2. CTRL+X > 3. CTRL+Z > 4. Press Save -> Error I'll focus on this one. It helps if you don't add more documents & different list of steps to this bug. :-)
Miklos Vajna committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/b784ee4feb554987eff1c7fdaff640abb340504d tdf#135016 DOCX export: fix unexpected error on save with undo/redo It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Miklos Vajna committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/949b42bb9fc32d0fcb99941a705ddfc8cae0b233 tdf#135016 DOCX export: fix unexpected error on save with undo/redo It will be available in 7.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified in Version: 7.1.0.0.alpha0+ Build ID: e2f4e65a7b8024c00b049eebf0d87637efda7f24 CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded @Miklos, thanks for fixing this issue!!