Bug 135130 - Tracking changes object still available after deleting if recording is on
Summary: Tracking changes object still available after deleting if recording is on
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
(earliest affected) release
Hardware: All All
: medium normal
Assignee: Not Assigned
Depends on:
Blocks: redlinehide-regressions
  Show dependency treegraph
Reported: 2020-07-25 11:53 UTC by Telesto
Modified: 2022-02-07 12:27 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:
Regression By:

Screencast (3.97 MB, video/mp4)
2020-07-25 11:54 UTC, Telesto
Example file (9.66 MB, application/vnd.oasis.opendocument.text)
2020-07-25 11:54 UTC, Telesto
Reduced Example file (142.71 KB, application/vnd.oasis.opendocument.text)
2020-07-25 12:00 UTC, Telesto

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-07-25 11:53:30 UTC
Tracking changes object still available after deleting if recording is on

Steps to Reproduce:
1. Open the attached file
2. Edit -> Track changes -> Show off & Record enabled
3. Go to page 60
4. Delete figure/frame by putting cursor at the right & pressing backspace

Actual Results:
Image still around

Expected Results:

Reproducible: Always

User Profile Reset: No

Additional Info:
Version: (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-07-25 11:54:22 UTC
Created attachment 163523 [details]
Comment 2 Telesto 2020-07-25 11:54:51 UTC
Created attachment 163524 [details]
Example file
Comment 3 Telesto 2020-07-25 11:56:04 UTC
Also in 6.2
Comment 4 Telesto 2020-07-25 11:57:02 UTC
Not in 6.0
Comment 5 Telesto 2020-07-25 12:00:30 UTC
Created attachment 163525 [details]
Reduced Example file
Comment 6 Telesto 2020-07-25 12:08:44 UTC
Bisected to:
author	Michael Stahl <Michael.Stahl@cib.de>	2018-11-30 17:54:41 +0100
committer	Thorsten Behrens <Thorsten.Behrens@CIB.de>	2018-12-18 22:30:17 +0100
commit 94c1af65367dcbc7272455cf6d4940252a289b62 (patch)
tree 98cced77a32f996d345ff3ead5ca6e300b05ffca
parent a44be0f4d6ee7321f0cdf441b054a10ad6285440 (diff)
sw_redlinehide: make layout based Show/Hide mode the default
remove ExperimentalMode checks

Comment 7 Telesto 2020-07-25 12:16:47 UTC
Bisected to
author	Michael Stahl <Michael.Stahl@cib.de>	2018-09-17 12:01:46 +0200
committer	Michael Stahl <Michael.Stahl@cib.de>	2018-09-19 10:18:33 +0200
commit ae3150b1e1863e854224c2e41c7e50991f945dad (patch)
tree 6bb9f6d6a5e48435c5051ccfc14bb08a3d6ef17a
parent 7e8b4756d95057f069467b34e7849f9354856578 (diff)
sw_redlinehide_2: replace SW_REDLINEHIDE with ExperimentalMode config
So we can get more testing & many bug reports.

Comment 8 Telesto 2020-07-25 12:24:55 UTC
Bisected to
author	Michael Stahl <Michael.Stahl@cib.de>	2018-07-26 14:12:53 +0200
committer	Michael Stahl <Michael.Stahl@cib.de>	2018-09-19 10:18:20 +0200
commit 4532845e22c10f252840887e55002307227b2390 (patch)
tree 741de848b9080b867a0042617a4c38b70b419630
parent d76b06da2eae5a8d62761ad95c92295cddd7b440 (diff)
sw_redlinehide_2: add *another* flag to DocumentRedlineManager
Sadly the SwRootFrame is created too late, so we have to store the
"ShowRedlineChanges" value that is imported from ODF settings.xml
somewhere, and we can't store it in SfxBaseModel::setViewData() because
it's not in "Views" map.

-> No warranties; bibisected the part where the whole frame + image being still visible after backspace.. so not exactly the same thing
Comment 9 thatho 2021-02-17 10:00:37 UTC
Similar behavior is present when find-replacing text:

Get some regular (lorem ipsum) text. 

Settings change:
Track changes: ON
Show changes: OFF

In Find-replace, a dot at the end of sentences is replaced to have an extra space after it.

Find (term enclosed in quotes): "."
Replace: ". "

".. "
In default font color.

* Turn Show changes ON, 
* visible: ".. " in track changes color
* Turn Show changes OFF
* visible: ". " (i.e., the expected result is shown now)

". "

I think it is one issue. If devs consider as not-the-same, I'm happy to open a new issue.

Version: (x64) / LibreOffice Community
Build ID: 2c8ffa41ec8e1ab2af95d5e033a445c17d29cf5a
CPU threads: 8; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: cs-CZ (cs_CZ); UI: en-US
Calc: CL
Comment 10 Buovjaga 2022-02-07 12:27:07 UTC
In latest master the image and its frame are both gone when I use backspace. In 7.1 the frame remained. I will close as WFM

Arch Linux 64-bit
Version: / LibreOffice Community
Build ID: 32c946c064cc2889bda2f46c1862e5100f0a257a
CPU threads: 8; OS: Linux 5.16; UI render: default; VCL: kf5 (cairo+xcb)
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded Jumbo
Built on 7 February 2022