Bug 135166 - FILEOPEN RTF: A part is marked as deleted change and should be so
Summary: FILEOPEN RTF: A part is marked as deleted change and should be so
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: notBibisectable, regression
Depends on:
Blocks: RTF-Opening RTF-Track-Changes
  Show dependency treegraph
 
Reported: 2020-07-26 18:10 UTC by Telesto
Modified: 2022-05-30 05:22 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file RTF (4.86 MB, application/rtf)
2020-07-26 18:11 UTC, Telesto
Details
ODT used the create RTF (2.39 MB, application/vnd.oasis.opendocument.text)
2020-07-26 18:11 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-07-26 18:10:45 UTC
Description:
FILEOPEN RTF: A part is marked as deleted change and should be so

Steps to Reproduce:
1. Open the attached file
2. Save as RTF
3. File reload

Actual Results:
A part of the second page (Bozkurt-Lotus Olayı(1926) is marked as deleted

Expected Results:
Should be so


Reproducible: Always


User Profile Reset: No



Additional Info:
This does go properly in
Version: 4.3.7.2
Build ID: 8a35821d8636a03b8bf4e15b48f59794652c68ba
Comment 1 Telesto 2020-07-26 18:11:09 UTC
Created attachment 163578 [details]
Example file RTF
Comment 2 Telesto 2020-07-26 18:11:30 UTC
Created attachment 163579 [details]
ODT used the create RTF
Comment 3 Xisco Faulí 2020-08-11 08:58:58 UTC
I'm confused. The steps talk about saving the document and reloading. the description about FILEOPEN. which one should I follow ?
Comment 4 Telesto 2020-08-11 10:19:49 UTC
(In reply to Xisco Faulí from comment #3)
> I'm confused. The steps talk about saving the document and reloading. the
> description about FILEOPEN. which one should I follow ?

There are two ways. Or open the ODT and save to RTF file reload. Or open the RTF directly
Comment 5 Xisco Faulí 2020-08-11 10:22:40 UTC
(In reply to Telesto from comment #4)
> (In reply to Xisco Faulí from comment #3)
> > I'm confused. The steps talk about saving the document and reloading. the
> > description about FILEOPEN. which one should I follow ?
> 
> There are two ways. Or open the ODT and save to RTF file reload. Or open the
> RTF directly

did you tried both ways with an older version to confirm it's a regression ?
Comment 6 BogdanB 2020-09-16 16:41:26 UTC
Confirm that after saving as RTF and reload part of the page 2 appear as deleted.

Version: 7.0.1.2
Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (ro_RO.UTF-8); UI: en-US
Calc: threaded

Telesto said in Description: This does go properly in Version: 4.3.7.2
Build ID: 8a35821d8636a03b8bf4e15b48f59794652c68ba
Comment 7 Aron Budea 2022-05-30 05:22:32 UTC
I tried to bibisect this using bibisect-44max with two different approaches.

1. Open ODT, save as RTF, reload, check the part with "Bozkurt-Lotus Olayı(1926)".

This was failing at the reload step for a long time, and got fixed with the following commit, but was already bad at that point. I didn't check where the failure started, I'm assuming it was still OK at that point.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=6b7239855d8babdc1bcc7742f79ce2df64d1e476
author		Miklos Vajna <vmiklos@collabora.co.uk>	2014-10-24 16:21:51 +0200
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2014-10-25 09:34:43 +0200

"fdo#82859 RTF import: don't try to set CustomShapeGeometry on a TextFrame"

2. Open ODT, save as RTF in latest of bibisect-43max, during bibisecting only load the RTF, check the relevant part.

This started crashing during load with the following commit.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=9dbf817fe5c5253fba0831aefa17575ae0ba3af1
author		Luboš Luňák <l.lunak@collabora.com>	2014-10-01 19:12:47 +0200
committer	Luboš Luňák <l.lunak@collabora.com>	2014-10-03 13:27:12 +0200

"handle scope of w:pPrChange and w:rPrChange properly (bnc#821804)"

The crash was fixed with the below commit, but the result was already bad.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=013ec10d4e89e86cbd53a88058defb7e97ebaa49
author		Miklos Vajna <vmiklos@collabora.co.uk>	2014-10-22 22:35:01 +0200
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2014-10-22 22:45:15 +0200

"i#84172 RTF import: handle nested groups inside redlines"

Marking not bibisectable.