Download it now!
Bug 135238 - Reject all removes image not included in track changes since 6.3
Summary: Reject all removes image not included in track changes since 6.3
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.3 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-07-28 14:24 UTC by Telesto
Modified: 2020-08-20 03:45 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (56.16 KB, application/vnd.oasis.opendocument.text)
2020-07-28 14:24 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-07-28 14:24:43 UTC
Description:
Reject all removes image not included in track changes

Steps to Reproduce:
1. Open the attached file
2. Sidebar -> Gallery
3. Drag an item empty area below the current content
4. Edit -> Track changes -> Reject all

Actual Results:
Images deleted

Expected Results:
Not so


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

and in
6.4

not seen in
6.3
Comment 1 Telesto 2020-07-28 14:24:54 UTC
Created attachment 163699 [details]
Example file
Comment 2 Attila Baraksó (NISZ) 2020-08-19 11:46:08 UTC
Reproduced in:

Version: 7.1.0.0.alpha0+
Build ID: ce6c6a5ad6c9dde09bb0bb0c51e16d828cfe0ef7
CPU threads: 6; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-GB (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 3 Attila Baraksó (NISZ) 2020-08-19 12:16:01 UTC
Bibisected using linux-64-6.4 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=d0aa2dbdf37aefe5b8d096fc5ea50cd13f87c5b0
author: Miklos Vajna <vmiklos@collabora.com>
committer: Miklos Vajna <vmiklos@collabora.com>
summary: sw: insert image: set anchor to at-char by default

Adding CC: Miklos Vajna
Comment 4 Miklos Vajna 2020-08-19 13:18:35 UTC
Is this reproducible on master? I just tried to drag a shape from the gallery and I get to-paragraph anchoring by default in that case.

Other than that, you can easily create a reproducer document (new Writer doc, enable track changes, insert an image, make sure it's anchored as at-char, reject the change) that will have the same problem, even before the above commit.

I imagine this may just work as expected: the image will be deleted when the text range containing the anchor of the image is deleted. Quite similar to deleting a text range that contains the anchor of at-char anchored images.

Probably this should be closed as resolved/notabug.
Comment 5 Telesto 2020-08-19 13:47:15 UTC
It's reproducible on master

Other than that, you can easily create a reproducer document (new Writer doc, enable track changes, insert an image, make sure it's anchored as at-char, reject the change) that will have the same problem, even before the above commit.

-> This is obvious I think; but not the point

The idea here is that 'tracking changes record being disabled' when adding the image. However with an 'old' history of changes present. So you add something to a paragraph which is marked as a change.. Disable record. Add a shape.. And reject changes.. To paragraph gets deleted including the image (which technically isn't record as change' and probably shouldn't be deleted. OTOH, this might be an exception on the rule; and not a big fan of exceptions as those produce really really specific quirky behavior when broken; being tremendously hard to trace back. But that's the other side of this case.  

This obviously bit of problematic case; I simply wanted to test what would happen :-). And did work differently in the past for whatever reason.

The bibisect result is slightly surprising; doesn't make much sense. Would have expected/ predicted a M. Stahl commit