This is a follow-up of bug 132911 found while creating a unittest Steps to reproduce 1. Open attachment 160593 [details] from bug 132911 with a debug build 2. Select all 3. Cut 4. Undo -> Crash Reproduced in Version: 7.1.0.0.alpha0+ Build ID: <buildversion> CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF-dbg, Branch:master, Time: 2020-07-28_03:35:20 Calc: threaded
Created attachment 163715 [details] gdb backtrace
Backtrace from Jenkins: https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/65100/consoleFull#-1847318127d893063f-7f3d-4b7e-b56f-4e0f225817cd
Hi Michael, Another issue introduced by https://cgit.freedesktop.org/libreoffice/core/commit/?id=4532845e22c10f252840887e55002307227b2390 author Michael Stahl <Michael.Stahl@cib.de> 2018-07-26 14:12:53 +0200 committer Michael Stahl <Michael.Stahl@cib.de> 2018-09-19 10:18:20 +0200 commit 4532845e22c10f252840887e55002307227b2390 (patch) tree 741de848b9080b867a0042617a4c38b70b419630 parent d76b06da2eae5a8d62761ad95c92295cddd7b440 (diff) sw_redlinehide_2: add *another* flag to DocumentRedlineManager ??? Sadly, I can't bisect it right now since it's not reproducible with the bisect repositories and I don't have a debug build to revert the commit mentioned above
On windows ( bisect repo ) the undo action does nothing an the table is not restored Version: 7.1.0.0.alpha0+ (x64) Build ID: a9f68d9d9ae8d7c8f79152055795044993b252ea CPU threads: 16; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: en-GB (en_GB); UI: en-US Calc: threaded it seems with a debug build it also crashes according to jenkins: https://ci.libreoffice.org/job/gerrit_windows/71142/console
Created attachment 163722 [details] bt with debug symbols On pc Debian x86-64 with master sources updated today, I got an assertion. (commit d3dd362c093916b4ad5d08844dacd291aa2c9b8f (HEAD -> master, origin/master, origin/HEAD) Author: Andrea Gelmini <andrea.gelmini@gelma.net> Date: Thu Jul 16 19:32:22 2020 +0200 Removed executable permission on data files )
The assert in sw/source/core/text/redlnitr.cxx:90 was added in author Michael Stahl <Michael.Stahl@cib.de> 2018-12-06 12:32:20 +0100 committer Michael Stahl <Michael.Stahl@cib.de> 2018-12-18 17:55:28 +0100 commit 63dba5203e8bc7fc390943cb8208ae904f18e3bb (patch) tree c7bb17457f2b7ec0b4f09adc3defbd7fb16e46bd parent 6364180490d350b95410693c170d3031a8aebede (diff) sw_redlinehide_4b: fix some problems with pathological table redlines
For the unittest, see https://opengrok.libreoffice.org/xref/core/sw/qa/extras/uiwriter/uiwriter3.cxx?r=99284a22#125
No assert triggered in a fresh debug build of LO Version 7.3.0.0.alpha0+ (86abf3a682b424dc0fcbccf030f5a0b9bfb81d8c) / Ubuntu.
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/67329f8b75101a78a00bf646bb2c3b9f4575aa5a tdf#135247: sw_uiwriter3: Add unittest It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
(In reply to Xisco Faulí from comment #4) > On windows ( bisect repo ) the undo action does nothing an the table is not > restored > > Version: 7.1.0.0.alpha0+ (x64) > Build ID: a9f68d9d9ae8d7c8f79152055795044993b252ea > CPU threads: 16; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win > Locale: en-GB (en_GB); UI: en-US > Calc: threaded > > it seems with a debug build it also crashes according to jenkins: > https://ci.libreoffice.org/job/gerrit_windows/71142/console This user-visible issue was fixed by https://cgit.freedesktop.org/libreoffice/core/commit/?id=4c9b292bb4ff3ad516dad37e2e0dd0ac8bbb4aa0 author Michael Stahl <Michael.Stahl@cib.de> 2020-07-27 16:33:06 +0200 committer Michael Stahl <michael.stahl@cib.de> 2020-07-28 09:59:28 +0200 Revert "tdf#132944 sw_redlinehide: delete of insert redline" This reverts commit ad0351b84926075297fb74abbe9b31a0455782af.