Bug 135261 - UI: Manage changes dialog is resizing for few seconds after every reject/clear formatting button press
Summary: UI: Manage changes dialog is resizing for few seconds after every reject/clea...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected
Depends on:
Blocks:
 
Reported: 2020-07-29 09:22 UTC by Telesto
Modified: 2020-09-10 08:25 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (2.50 MB, application/vnd.oasis.opendocument.text)
2020-08-20 15:30 UTC, Telesto
Details
Screencast (753.08 KB, video/mp4)
2020-08-20 15:31 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-07-29 09:22:12 UTC
Description:
UI: Manage changes dialog is resizing for few seconds after every reject/clear formatting button press

Steps to Reproduce:
1. Open the attached file
2. Edit -> Track changes -> Manage changes
3. Start pressing reject/clear formatting

Actual Results:
Shrinks expands

Expected Results:
Same size


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-07-29 09:22:47 UTC
Not in
Version: 6.3.0.0.beta1+ (x86)
Build ID: 5cfac16dbd4af456a7fb6d52c8953c69a72ba2ba
CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 2 Attila Baraksó (NISZ) 2020-08-19 12:34:33 UTC
The attachment is missing, please add again, thanks!
Comment 3 Telesto 2020-08-20 15:30:12 UTC
Created attachment 164501 [details]
Example file
Comment 4 Telesto 2020-08-20 15:31:07 UTC
Created attachment 164502 [details]
Screencast
Comment 5 Telesto 2020-08-20 15:33:41 UTC
@Caolan
Is it possible to initialize the Manage Changes dialog based on the larger "Reject/Clear formatting label". Instead adjusting the size continuously based on the content? 

See screencast
Comment 6 Caolán McNamara 2020-08-20 19:42:25 UTC
Yes is possible. (but it might then look fairly horrible with a huge mostly empty button).

To try it out see svx/source/dialog/ctredlin.cxx and the "m_xReject" button. There is a place where the two different strings are set. To make it always the same size then in the ctor you could set each string and after each set then query the size with "get_preferred_size" and then set the larger size with "set_size_request" and the button will then be unchanged in size regardless of which string is then used
Comment 7 Attila Baraksó (NISZ) 2020-08-21 05:52:49 UTC
Reproduced in:

Version: 7.1.0.0.alpha0+
Build ID: ce6c6a5ad6c9dde09bb0bb0c51e16d828cfe0ef7
CPU threads: 6; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-GB (hu_HU.UTF-8); UI: en-US
Calc: threaded
Comment 8 Attila Baraksó (NISZ) 2020-08-21 05:58:17 UTC
I'm too newbie to decide, this is a bug or not a bug, so I just leave this here... :)

Bibisected using linux-64-6.4 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=f35825e85f59e0fd155c68d63260169cd3cb38c9
author: Caolán McNamara <caolanm@redhat.com>
committer: Caolán McNamara <caolanm@redhat.com>
summary: Resolves: tdf#127218 allow changes dialog to shrink when button text changes
Comment 9 Heiko Tietze 2020-09-10 08:25:30 UTC
As there is request for UX input: dialogs with a user-defined size should not change on reloading. So ideally we size only at initialization but not later.