Bug 135263 - Lots of changes lost after changing font/ font size
Summary: Lots of changes lost after changing font/ font size
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
Inherited From OOo
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-29 09:32 UTC by Telesto
Modified: 2020-07-29 10:55 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (11.84 KB, application/vnd.oasis.opendocument.text)
2020-07-29 09:32 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-07-29 09:32:08 UTC
Description:
Lots of changes lost after changing font

Steps to Reproduce:
1. Open the attached file
2. Edit -> Track Changes -> Manage -> Notice the list
3. Close dialog
4. CTRL+A
5. Change font size/ apply bold/ change font 
6. Edit -> Track Changes -> Manage -> Notice the list

Actual Results:
Trashing changes pretty easy

Expected Results:
Don't think this should work this way


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-07-29 09:32:29 UTC
Created attachment 163728 [details]
Example file
Comment 2 Telesto 2020-07-29 09:34:02 UTC
Also in
LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4

Not knowing to much about track changes etc..
Comment 3 Heiko Tietze 2020-07-29 10:02:51 UTC
No idea why previous TC get lost (and not a UX topic). Michael do you?
Comment 4 Michael Stahl (allotropia) 2020-07-29 10:18:42 UTC
well those tracked changes are all format changes <text:format-change> and writer can't actually record the previous formatting so if you add a new format change it will just overwrite the existing ones.

i see an obvious UI problem here, the Manage Changes dialog shows the format changes with the same green + icon as insert changes, which i find confusing; delete changes get a red X.
Comment 5 Heiko Tietze 2020-07-29 10:23:46 UTC
(In reply to Michael Stahl (CIB) from comment #4)
> well those tracked changes are all format changes <text:format-change> and
> writer can't actually record the previous formatting...

So it's NAB.
Comment 6 Telesto 2020-07-29 10:45:00 UTC
(In reply to Michael Stahl (CIB) from comment #4)
> well those tracked changes are all format changes <text:format-change> and
> writer can't actually record the previous formatting so if you add a new
> format change it will just overwrite the existing ones.

From usability point of view not the nicest thing, IMHO. Have seen quite of number of cases where you simple lose changes. Which makes it not to trustworthy to use. IMHO. 

I'm still not getting how undo is capable to undo every change, will track changes ins't able to register it show. 

Can they undo information not somehow being put into track changes recording. Probably wishful thinking..
Comment 7 Michael Stahl (allotropia) 2020-07-29 10:55:17 UTC
you're right of course, iirc Word can do this sort of thing, it's just a matter of finding someone with enough time to implement it...

the implementation of Undo and Tracked Changes is almost entirely separate currently.