Bug 135383 - Image frame at the wrong position after undo with DOCX file
Summary: Image frame at the wrong position after undo with DOCX file
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, implementationError
Depends on:
Blocks: Undo-Redo DOCX-Anchor-and-Text-Wrap
  Show dependency treegraph
 
Reported: 2020-08-02 10:36 UTC by Telesto
Modified: 2022-02-23 15:53 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
sample file (128.30 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-08-04 11:57 UTC, Xisco Faulí
Details
Bugdoc without textboxes. (127.58 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-08-18 15:24 UTC, Miklos Vajna
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-08-02 10:36:37 UTC Comment hidden (obsolete)
Comment 1 Telesto 2020-08-02 10:37:56 UTC
Not in
Version: 7.0.0.0.beta1+ (x64)
Build ID: 2891e91a513520d68ea2b8c59c14335861a15253
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 2 Telesto 2020-08-02 10:48:07 UTC Comment hidden (obsolete)
Comment 3 Telesto 2020-08-02 10:48:40 UTC
Fine with
Versie: 4.2.0.4 
Build ID: 05dceb5d363845f2cf968344d7adab8dcfb2ba71
Comment 4 Telesto 2020-08-02 10:52:32 UTC
Off topic, saving to DOC is also flawed. Has similarity with bug 134948
Comment 5 Xisco Faulí 2020-08-04 11:57:05 UTC
Created attachment 163933 [details]
sample file

No need to export the ODT to DOCX every time.
Steps to reproduce:
1. Open attached document
2. Change frame's anchor to 'As Character'
3. Undo

-> The frame doesn't come back to the previous position
Comment 6 Xisco Faulí 2020-08-04 12:00:15 UTC
The issue started to happen after

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7596e26fd259ce5445212949403e7cd32303b2bd

author	Miklos Vajna <vmiklos@collabora.co.uk>	2014-06-24 17:11:25 +0200
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2014-06-24 17:47:40 +0200
commit 7596e26fd259ce5445212949403e7cd32303b2bd (patch)
tree cda3ea0acb777fa8ce97e1b8485648e62078ca53
parent 212dce21b62a4cfb85406bebe54ee07545516e21 (diff)
Add SwTextBoxHelper::findShapes

Bisected with: bibisect-44max

Adding Cc: to Miklos Vajna
Comment 7 Miklos Vajna 2020-08-18 15:24:07 UTC
Created attachment 164412 [details]
Bugdoc without textboxes.

I can reproduce the bug, but this problem is there before the above commit already. I attach a document which has the same shape, but without text on it. If you use the navigator to select the shape, set the anchor to as-char and then undo it, you'll see that the same problem happens without textboxes as well. The newer bugdoc allowed me to reproduce the problem with the previous commit in linux-44max.git as well.

So yes, it makes sense to fix this, but it's not a regression, I think. (At least it was there before the above commit already.)
Comment 8 Miklos Vajna 2020-08-18 15:24:28 UTC
Adjusting keywords accordingly.