Bug 135696 - Image doesn't return to original position on undo
Summary: Image doesn't return to original position on undo
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Undo-Redo
  Show dependency treegraph
 
Reported: 2020-08-13 10:08 UTC by Telesto
Modified: 2021-08-05 08:24 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Example file (55.76 KB, application/vnd.oasis.opendocument.text)
2020-08-13 10:09 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-08-13 10:08:52 UTC
Description:
Image doesn't return to original position on undo

Steps to Reproduce:
1. Open the attached file
2. Select the figure frame
3. Drag it somewhere outside the table
4. Press undo

Actual Results:
Nothing

Expected Results:
Moves back


Reproducible: Always


User Profile Reset: No



Additional Info:
Found in
Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

not in
Version: 6.4.0.0.beta1+ (x64)
Build ID: 20be5cd0bdc57d812bf34a2debfe48caa51de881
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: GL; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: CL
Comment 1 Telesto 2020-08-13 10:09:04 UTC
Created attachment 164236 [details]
Example file
Comment 2 Eric Proegler 2021-02-28 03:58:26 UTC
Confirmed undo does not move image frame back to original position with 7.1.1.1 and 7.2.0.0, using example doc. Moving just the image itself does revert successfully with undo. The document can be closed after these failed reverts, and reopens with the original formatting. Moving the image frame inside the table also shows the behavior. 

It appears it is necessary to have the frame in a table as in the sample doc. When I copied the frame into a doc by itself, I was not able to reproduce the problem. 

Relocating the frame via properties menu shows the same behavior reported. Also found that changing other frame properties such as resizing the frame, changing shadow style, or adding padding produces a similar effect. The change can be undone, but does not appear to revert the change until the document is reopened. 
 
If I move the image first, then move the frame, Undo pops the image back to the frame in its altered location. The undo menu item does not show any steps remaining to revert. 
 
Other observations:
- Repeated testing resulted in numerous triggered recoveries of the document after closing altered doc; frame moved, but no saving. This is happening even when LO did not exit abnormally, and the last modified date of the file does not change. 
- Several opens of this doc after "unsaved" modification in one LO session has resulted in rendering problems until LO is restarted. 
- Preview images of the doc after closing it in the same LO session show the unsaved changes in the thumbnail in the Recent Documents screen, though they weren’t saved. .
- These observations suggest a temp file state persists for the file, and it is not being updated when the document is closed.
- A user who sees frame properties - location, size, padding, etc - fail to revert on undo could become frustrated and lose confidence in the application.


Reproduced Versions:
 
Version: 7.1.1.1 / LibreOffice Community
Build ID: 575c5867c4cc13d7ae78f9ce39a54a52ed38c769
CPU threads: 16; OS: Mac OS X 10.15.7; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
 
Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 3a1e3bd2bb71d084233dfb791c1d0c3dd81b43e5
CPU threads: 16; OS: Mac OS X 10.15.7; UI render: default; VCL: osx
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 3 Natali Eroshenko 2021-08-05 07:40:45 UTC
 Eric Proegler, you can log the error separately
Comment 4 Natali Eroshenko 2021-08-05 07:41:24 UTC
don`t repro in Version: 7.1.5.2 (x64) / LibreOffice Community
Build ID: 85f04e9f809797b8199d13c421bd8a2b025d52b5
CPU threads: 6; OS: Windows 10.0 Build 19042; UI render: Skia/Vulkan; VCL: win
Locale: en-US (ru_RU); UI: en-US
Calc: threaded
Comment 5 Natali Eroshenko 2021-08-05 07:43:44 UTC Comment hidden (obsolete)
Comment 6 Telesto 2021-08-05 08:24:40 UTC
Version: 7.3.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 36efb384a66b6dd645e0ae80fd7df68370a9dc8b
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL