Bug 135743 - With RTL UI, menubutton dialogs appear shifted from their appropriate position
Summary: With RTL UI, menubutton dialogs appear shifted from their appropriate position
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All other
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.1.0 target:7.0.2
Keywords:
: 136221 (view as bug list)
Depends on:
Blocks: RTL-UI
  Show dependency treegraph
 
Reported: 2020-08-14 06:57 UTC by Ossama Nasser
Modified: 2024-08-02 23:25 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
The problem at hand (289.37 KB, video/mp4)
2020-08-14 06:57 UTC, Ossama Nasser
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ossama Nasser 2020-08-14 06:57:27 UTC
Created attachment 164296 [details]
The problem at hand

I use elementary OS Hera, and I am trying Libreoffice 7.

I use the Arabic interface of the application, and there is a problem when opening dialog menus from the toolbar, they shift to the left like described in the video

The problem is not limited to Writer.
Comment 1 V Stuart Foote 2020-08-14 14:00:30 UTC
Adjusted summary from the screen capture.
Assume elementary OS 5.1 (Hera) is non-gtk3.

Caolán, one for you?
Comment 2 Eyal Rozenberg 2020-08-14 15:38:11 UTC
(In reply to V Stuart Foote from comment #1)
> Assume elementary OS 5.1 (Hera) is non-gtk3.

According to the wiki page about Elementary OS:
https://en.wikipedia.org/wiki/Elementary_OS

it's an Ubuntu-based Linux distribution. So, why would it not be gtk3?
Comment 3 Ossama Nasser 2020-08-14 16:40:58 UTC
Elementary OS Hera (5.1) uses GTK3 to build its own desktop environment Pantheon
Comment 4 Caolán McNamara 2020-08-14 20:17:09 UTC
I can see this under X, wayland is ok
Comment 5 Commit Notification 2020-08-17 08:18:20 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/00c9b04028e5e2ed838313389f74c61b09caee2b

tdf#135743 ignore size-allocations triggered by an embedded SalObject

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2020-08-17 10:17:26 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4d7bf28b2c09984cad88ee6760cbdbb6886b1545

tdf#135743 only overwrite our geometry with the valid entries

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Commit Notification 2020-08-17 10:18:36 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a59f45d5808ed4d4767608246f0b9cf49e6b5276

Related: tdf#135743 position combobox dropdowns correctly for RTL

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Caolán McNamara 2020-08-17 10:20:06 UTC
looks good in master now, backports to 7-0 in gerrit
Comment 9 Commit Notification 2020-08-22 02:21:21 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/814416d20f913bb823ba2348d2a9a76e7eaa7d76

tdf#135743 ignore size-allocations triggered by an embedded SalObject

It will be available in 7.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2020-08-22 02:23:33 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/e08e75a7dac629c67c35945d23d5356d40e98c1f

tdf#135743 only overwrite our geometry with the valid entries

It will be available in 7.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2020-08-22 02:24:44 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/4ec79a49b2885d4d5074c87cbb15f2d3c207ccf4

Related: tdf#135743 position combobox dropdowns correctly for RTL

It will be available in 7.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Yotam Benshalom 2020-08-29 21:25:15 UTC
*** Bug 136221 has been marked as a duplicate of this bug. ***