Bug 135875 - UI: Order of paragraph style tabs. Font effect should be followed by highlighting
Summary: UI: Order of paragraph style tabs. Font effect should be followed by highligh...
Status: UNCONFIRMED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Styles-Dialog Character-Dialog
  Show dependency treegraph
 
Reported: 2020-08-18 10:33 UTC by Telesto
Modified: 2021-08-12 16:38 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Screenshot (22.76 KB, image/png)
2020-08-18 10:33 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-08-18 10:33:00 UTC
Description:
UI: Order of paragraph style tabs. Font effect should be followed by highlighting

Steps to Reproduce:
1. See screenshot
2. Font, Font effects followed by Position. I would expect Highlighting (as it's some similarity with font Effects). I even consider 'highlighting part of font effects), that's probably impossible to combine

Actual Results:
Next to font effect tab is position tab

Expected Results:
I would expect the highlighting tab (as it some kind of font effect)


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-08-18 10:33:17 UTC
Created attachment 164405 [details]
Screenshot
Comment 2 andreas_k 2020-09-08 07:48:03 UTC
So the Paragraph Style Dialog has the following tab arrangement:
1. Organiser
2. Indents & Spacing
3. Alignment
4. Text Flow
5. Font
6. Font Effects
7. Highlight (new)
8. Position
9. Tabs
10. ...

I'm fine with this, but than it should be the same sorting in character style dialog.
Comment 3 andreas_k 2020-09-08 07:48:29 UTC
Is there a reason that Font Color and Highlight Color are not in the Font Effects tab? Why is there an separate Highlight tab? You can't Highlight with an gradient or an image isn't it?
Comment 4 andreas_k 2020-09-08 07:54:51 UTC
As the Styles dialog has a lot of tabs, I would prefer to reduce the Highlight tab and add an dropdown widget for Highlight color next to font color.
Comment 5 Telesto 2020-09-14 06:45:22 UTC
(In reply to andreas_k from comment #4)
> As the Styles dialog has a lot of tabs, I would prefer to reduce the
> Highlight tab and add an dropdown widget for Highlight color next to font
> color.

+! assuming no reasoning behind the tab
Comment 6 Heiko Tietze 2020-09-14 08:39:25 UTC
(In reply to andreas_k from comment #3)
> Is there a reason that Font Color and Highlight Color are not in the Font
> Effects tab?

Don't see the background color (aka highlighting) being a kind of font effect.

About shuffling tabs around please keep in mind that users are familiar with the organization and maybe comprehend the upper row as "secondary", attributes that are not changed often. Plus, CTL and CJK (Tools > Options > Language > Asian/ Complex) add more tabs to the dialog.

Code pointer: sw/source/ui/fmtui/tmpdlg.cxx > AddTabPage() 
(if that won't work look through the code for RID_SVXPAGE_BKG)
Comment 7 Telesto 2020-09-14 08:59:23 UTC
(In reply to Heiko Tietze from comment #6)
> (In reply to andreas_k from comment #3)
> > Is there a reason that Font Color and Highlight Color are not in the Font
> > Effects tab?

I don't see Font color being a 'font effect' either.  Only transparency for font is. So add transparency to highlighting and you have a highlight effect ;-). Or move they Font color to Highlighting tab (not that would like that, but for sake of the argument) 

I have always to search for highlighting tab. And doesn't add much value (to have it separately). Waste of space..

I do see the 'text box animation effects' as font effects, but those aren't in the dialog either (of course different reasoning behind that)

Also highlighting and font color a placed next each other in the sidebar/toolbar. So in that way 'connected' already, IMHO
Comment 8 andreas_k 2020-09-14 09:16:26 UTC
(In reply to Telesto from comment #7)
> (In reply to Heiko Tietze from comment #6)
> > (In reply to andreas_k from comment #3)
> > > Is there a reason that Font Color and Highlight Color are not in the Font
> > > Effects tab?
> 
> I don't see Font color being a 'font effect' either.  Only transparency for
> font is. So add transparency to highlighting and you have a highlight effect
> ;-). Or move they Font color to Highlighting tab (not that would like that,
> but for sake of the argument) 


Font Color and Highlight color are ALWAYS in the UI next to each other (toolbar, sidebar, ...) In the dialog there is a separate Highlighting tab. In the rest of the UI it's always Highlight color in the Dialog it's called Highlighting so from my point of view it's confuse cause of different arrangement, layout and label. Hightlighting can be also Background color or anything else.
Comment 9 Thomas Lendo 2020-09-15 07:57:13 UTC
I share Heiko's concerns. Moving tabs must have other locales in mind (also if the length of the localized tab title strings will force a third line of tabs what should be avoided). And highlighting has - strictly speaking - nothing to do with fonts.

Font Effects and Position tabs are highly related as they change characters (overlined or superscript - it's both changing a character). For me, they should be next to each other.


Despite all that I see the benefit of one tab less in the dialog.

What I can see at a first glance is that the Highlighting tab has one benefit over the color picker widget in the Font Effects tab: You can add a color to the custom palette.

Adding the highlighting color will mess up the ordering of the whole commands in the Font Effects tab with its columns.


Changing the Highlighting tab affects
* the Character dialog in Writer and Impress,
* the Paragraph Style dialog in Writer,
* the Drawing and Presentation style dialogs in Impress and Draw.