Bug 135918 - FILEOPEN XLSX Rotated shapes near sheet edges move
Summary: FILEOPEN XLSX Rotated shapes near sheet edges move
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All All
: medium normal
Assignee: Balázs Regényi
URL:
Whiteboard: target:7.1.0
Keywords: filter:xlsx, implementationError
Depends on:
Blocks: OOXML-Shapes
  Show dependency treegraph
 
Reported: 2020-08-19 12:14 UTC by NISZ LibreOffice Team
Modified: 2020-08-31 21:46 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Excel with shape next to upper border, rotated to horizontal direction (7.88 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2020-08-19 12:14 UTC, NISZ LibreOffice Team
Details
Screenshot of the horizontally rotated shape side by side in Excel and Calc (109.89 KB, image/png)
2020-08-19 12:14 UTC, NISZ LibreOffice Team
Details
Example file from Excel with shape next to left edge, rotated to vertical direction (9.27 KB, application/vnd.openxmlformats-officedocument.spreadsheetml.sheet)
2020-08-19 12:15 UTC, NISZ LibreOffice Team
Details
Screenshot of the vertically rotated side by side in Excel and Calc (130.32 KB, image/png)
2020-08-19 12:15 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2020-08-19 12:14:06 UTC
Created attachment 164465 [details]
Example file from Excel with shape next to upper border, rotated to horizontal direction

Attached Excel-made documents contain rotated shapes placed next to the sheets upper/left edges.
When opened in Calc the shapes are misplaced from the top / left of the sheet, as if their position were calculated without considering the result of the rotation first.


Steps to reproduce:
    1. Open attached documents

Actual results:
Shapes are vertically/horizontally shifted.

Expected results:
Shapes retain their position.

LibreOffice details:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

Additional Information: 

This started after the fix to bug #83593 – before that the rotation did not work, but there was no position shift either.
Comment 1 NISZ LibreOffice Team 2020-08-19 12:14:41 UTC
Created attachment 164466 [details]
Screenshot of the horizontally rotated shape side by side in Excel and Calc
Comment 2 NISZ LibreOffice Team 2020-08-19 12:15:18 UTC
Created attachment 164467 [details]
Example file from Excel with shape next to left edge, rotated to vertical direction
Comment 3 NISZ LibreOffice Team 2020-08-19 12:15:33 UTC
Created attachment 164468 [details]
Screenshot of the vertically rotated side by side in Excel and Calc
Comment 4 Commit Notification 2020-08-24 09:03:40 UTC
Regényi Balázs committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3e85b22769a4b02744a7006d7dc772973c0093f5

tdf#135918 XLSX DrawingML shape import: fix needless displacement

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 BogdanB 2020-08-31 21:46:23 UTC
Verified in
Version: 7.1.0.0.alpha0+
Build ID: e2f4e65a7b8024c00b049eebf0d87637efda7f24
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (ro_RO.UTF-8); UI: en-US
Calc: threaded