Bug 135935 - Can't open help page insert chart on calc
Summary: Can't open help page insert chart on calc
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Documentation (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Rafael Lima
URL:
Whiteboard: target:7.4.0 target:7.3.1 target:7.2.6
Keywords:
Depends on:
Blocks: Help-Link
  Show dependency treegraph
 
Reported: 2020-08-20 07:03 UTC by sawakaze
Modified: 2022-01-23 04:00 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
screenshot (226.37 KB, application/vnd.oasis.opendocument.graphics)
2020-08-20 07:04 UTC, sawakaze
Details
screencast on gtk3 (794.64 KB, video/x-matroska)
2020-09-01 23:31 UTC, sawakaze
Details
screencast on kf5(kde) (925.43 KB, video/x-matroska)
2020-09-01 23:33 UTC, sawakaze
Details
working (554.67 KB, video/mp4)
2020-09-02 18:36 UTC, BogdanB
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sawakaze 2020-08-20 07:03:17 UTC
Description:
after following step, help page was not opened.
and "not found page" was opened(screenshot)

Steps to Reproduce:
1. open calc
2. menu > Insert > Chart 
--> open chart type window
3. press help button

Actual Results:
not fount page was opened.

Help ID: vcl/ui/wizard/Wizard

Expected Results:
chart type help page is opened.


Reproducible: Always


User Profile Reset: No



Additional Info:
I confirm this version

Version: 7.1.0.0.alpha0+
Build ID: <buildversion>
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: ja-JP (ja_JP.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-08-19_02:56:36
Calc: threaded

Linux Ubuntu MATE
Comment 1 sawakaze 2020-08-20 07:04:20 UTC
Created attachment 164482 [details]
screenshot
Comment 2 BogdanB 2020-08-20 11:39:47 UTC
Works in
Version: 7.0.0.3 (x64)
Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: ro-RO (ro_RO); UI: en-US
Calc: threaded

This is the help page it opens:
https://help.libreoffice.org/7.0/en-US/text/schart/01/wiz_chart_type.html?System=WIN&DbPAR=CALC&HID=CHART2_HID_SCH_WIZARD_ROADMAP#bm_id2511368
Comment 3 sawakaze 2020-08-25 23:46:50 UTC
as only LibreOffice 7.1.0.0 alpha0+, i seem to confirm this bug.
Comment 4 Olivier Hallot 2020-09-01 22:08:53 UTC
Can't confirm with

Version: 7.1.0.0.alpha0+
Build ID: 8636da690547e8d893d5ea7bcc7bf2ce787c44ec
CPU threads: 16; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: en-US (en_US.UTF-8); UI: pt-BR
Calc: CL

Opened page:

file:///home/tdf/git/core/instdir/help/pt-BR/text/schart/01/wiz_chart_type.html?System=UNIX&DbPAR=CHART&HID=CHART2_HID_SCH_WIZARD_ROADMAP#bm_id2511368
Comment 5 sawakaze 2020-09-01 23:30:32 UTC
On 2020/8/30 master daily build, I test two env.

(1) gtk3 

Version: 7.1.0.0.alpha0+
Build ID: 0d2dbcbebf0004e690feb91c38dd478a32dc6255
CPU threads: 1; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: ja-JP (ja_JP.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-08-30_17:39:21
Calc: threaded

Result: Can't open chart wizard page

---------------

(2) kf5 (KDE)

Version: 7.1.0.0.alpha0+
Build ID: 0d2dbcbebf0004e690feb91c38dd478a32dc6255
CPU threads: 1; OS: Linux 5.4; UI render: default; VCL: kf5
Locale: ja-JP (ja_JP.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-08-30_17:39:21
Calc: threaded

Result: can open chart wizard page

---------

I seem this bug is on gtk3 env.

if I description is uncleared, please attachement screencast.
Comment 6 sawakaze 2020-09-01 23:31:56 UTC
Created attachment 164997 [details]
screencast on gtk3

screen cast On gtk3 env
Comment 7 sawakaze 2020-09-01 23:33:06 UTC
Created attachment 164998 [details]
screencast on kf5(kde)

screen cast kf5
Comment 8 QA Administrators 2020-09-02 00:03:56 UTC Comment hidden (obsolete)
Comment 9 BogdanB 2020-09-02 18:32:53 UTC
I have notice that sawakaze have another interface (japanese).
Maybe if we test on another user interface there we can reproduce the bug.
Comment 10 BogdanB 2020-09-02 18:34:34 UTC
I tested now with romanian user interface and no problem.

Version: 7.1.0.0.alpha0+
Build ID: e69f547bce7de376a0af464c5f7af5e7d2c8784a
Fire CPU: 4; OS: Linux 5.4; Redare UI: implicit; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: ro-RO
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-06-23_15:52:52
Calc: threaded
Comment 11 BogdanB 2020-09-02 18:36:18 UTC
Created attachment 165043 [details]
working

I made a video to see that is working on my LO with gtk3
Comment 12 BogdanB 2020-09-02 18:39:02 UTC
Now I succeded to reproduce the bug:

- first I was on english
- after that on romanian user interface
- came back to english user interface and I could reproduce the bug

The same error:
Could not find Help page (404).
That is an error. Possible causes are:

The page does not exists and must be created.

The page exists, but the Help ID is wrong or missing.

Use the Module, Contents, Index and Search selectors to find the right page.

The following data could be helpful in locating the error:

Help ID: vcl/ui/wizard/Wizard

Confirm with:
Version: 7.1.0.0.alpha0+
Build ID: e69f547bce7de376a0af464c5f7af5e7d2c8784a
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-06-23_15:52:52
Calc: threaded
Comment 13 BogdanB 2020-09-02 18:40:25 UTC
Everytime I try now I can reproduce this bug.
Comment 14 Olivier Hallot 2021-06-08 11:19:12 UTC
Reproducing Bogdan's procedure, the issue happens (missing Help page). 

To overcome, you must select one of the available chart type and then click on the Help button.

My take is that if no selection is made, the Help button will open a missing Help page indicated by vcl/ui/wizard/Wizard, which is the ID of the outer frame holding the service button row. On selecting a chart type (any chart type, clicking in the inner dialog area), the ID changes to the inner dialog contents which then points to the right Help page.

Does it make sense?
Comment 15 Rafael Lima 2022-01-03 22:19:06 UTC
(In reply to Olivier Hallot from comment #14)
> My take is that if no selection is made, the Help button will open a missing
> Help page indicated by vcl/ui/wizard/Wizard, which is the ID of the outer
> frame holding the service button row. On selecting a chart type (any chart
> type, clicking in the inner dialog area), the ID changes to the inner dialog
> contents which then points to the right Help page.
> 
> Does it make sense?

It seems plausible. I am using kf5 and when I click the Help button without selecting anything in the dialog I get redirected to:

https://help.libreoffice.org/7.4/en-US/text/swriter/01/mailmerge00.html?System=UNIX&DbPAR=CHART&HID=vcl/ui/wizard/Wizard#bm_id1926107

which is where "vcl/ui/wizard/Wizard" is currently landing in LO 7.4.

Clicking any element in the dialog fixes the problem (on kf5).

It is important to note that this problem happens on kf5 and gen. Using gtk3 back-end this problem does not happen.

I guess it has something to do with how "set_page_side_help_id" is implemented in:
https://opengrok.libreoffice.org/xref/core/vcl/unx/gtk3/gtkinst.cxx#7427

And here:
https://opengrok.libreoffice.org/xref/core/vcl/source/app/salvtables.cxx#1992

Also note that the Chart Wizard inherits from vcl::RoadmapWizardMachine.

I believe this is no longer a Documentation bug, but instead a VCL bug. Can anyone confirm, please?
Comment 16 Rafael Lima 2022-01-03 23:40:03 UTC
The patch proposed in Gerrit fixes the issue in kf5, gen and gtk3.
https://gerrit.libreoffice.org/c/core/+/127783
Comment 17 Commit Notification 2022-01-21 16:56:40 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/67e88d173fb56a2628a5464d56276134bf6f65a2

tdf#135935 Ensure help page is opened in chart creation Wizard dialog

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 18 Caolán McNamara 2022-01-21 16:59:50 UTC
merged to trunk, backport to 7-3 and 7-2 in gerrit
Comment 19 Commit Notification 2022-01-22 03:47:27 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/48b4720b309acb23a8580d6eb36a00899509af38

tdf#135935 Ensure help page is opened in chart creation Wizard dialog

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 20 Commit Notification 2022-01-22 03:48:40 UTC
Rafael Lima committed a patch related to this issue.
It has been pushed to "libreoffice-7-2":

https://git.libreoffice.org/core/commit/2db11ed1cdd0a7f7870230bb77519e5f9f4d054b

tdf#135935 Ensure help page is opened in chart creation Wizard dialog

It will be available in 7.2.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Commit Notification 2022-01-22 07:08:36 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/13168ca1f6da1f198626f2d9b926fa2426cf12f6

Related: tdf#135935 set some hints as to what widget should have starting focus

It will be available in 7.3.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 22 Commit Notification 2022-01-23 04:00:35 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/465c3ad95059f0efa13c8027f7383c4d20a5b2ff

Related: tdf#135935 set some hints as to what widget should have starting focus

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.